-
Notifications
You must be signed in to change notification settings - Fork 66
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor KBreadcrumbs to utilize KListWithOverflow #693
Comments
Hey @MisRob I want to work on this Issue Please Assign this to me |
Hey @sruthin21! Thank you! I just assigned you this issue. Please let us know if you have any question. I was thinking to propose something for this issue but probably will be able to do that tomorrow :). But you can start looking at the issue for now. |
@AlexVelezLl Thank You for assigning |
Hey @sruthin21! I am back with some things we will need for this:
There will problably be a lot of things that I am missing, so please let us know if you have any questions 🤗. |
What this throttle function do And what will be the output of the function |
This is just a way to optimize the number of calls we do to the |
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
In times when
KListWithOverflow
component didn't yet exist, we used the "duplicate markup" technique in theKBreadcrumbs
component to achieve their overflow behavior when breadcrumb items were collapsed to the dropdown menu on the left:The duplicate markup technique is based on keeping a hidden copy of visible breadcrumbs (
breadcrumbs-offscreen
) in the markup so that elements are available for recalculations:kolibri-design-system/lib/KBreadcrumbs.vue
Lines 84 to 118 in 9d2a147
Now that we have
KListWithOverflow
that is designed to take care of overflowing items to a menu, it would be good to remove this other implementation fromKBreadcrumbs
and refactor them to utilizeKListWithOverflow
instead.The Value Add
Easier maintenance, development efficiency.
Guidance
Note that
KListWithOverflow
will likely need some updates to be able to display the button on the left side, and possibly some other adjustments so that these two components can collaborate smoothly.Acceptance criteria
KBreadcrumbs
andKListWithOverflow
are used:The text was updated successfully, but these errors were encountered: