Importing using ES6 but jQuery is loaded externally

[dobromir-hristov]

Ok so my situation is a bit sticky. I am developing a WordPress theme for a client, but I am using ES6 with Babel and Browserify for my custom code. Problem is I cant just deregister jQuery because the majority of WP plugins require it.
So in every ES6 module I just const $ = window.jQuery (because I just couldn't make browserify shim to work properly).
But now when I import 'jquery-circle-progress' I jsut get that circleProgress is not a function of jQuery. Any suggestions how I should proceed ?
At this point I just added the whole plugin into my Libraries JS stack, and its available everywhere, but that's not cool.

[kottenator]

Seems like a bug. I'll take a closer look.

[andreiglingeanu]

@dobromir-hristov I fixed that problem by marking jquery module as a global variable that comes from window.jQuery, like that. I am using webpack, though. I bet browserify have such an option too.

[andreiglingeanu]

@kottenator And I'm having no problem with jquery-circle-progress picking up window.jQuery, as long as you indicate webpack that jquery module refers to window.jQuery variable. No one even cares about the source of jquery module.

[andreiglingeanu]

I bet browserify have such an option too.

Confirmed.

[kottenator]

@andreiglingeanu - I think I've found a bug in the UMD template I'm using (this line should assign a value, not a function). I'll take care.

[kottenator]

So, after investigation, it's not a UMD bug but rather UMD specific decision.

They decided to export a factory function, not jQuery. The function needs to be called to initialiaze the plugin:

import jcp from 'jquery-circle-progress';
jcp();

I find this decision too complicated, so I've updated the UMD code. Now this will work (as expected):

import 'jquery-circle-progress';
// that's it, plugin is initiated using `$ = require('jquery')`

I'm releasing version 1.2.1 now.

[kottenator]

[email protected] released.

Now few words about browserify-shim configuration: see my gist.

I believe the bug is fixed. I'm closing this ticket. @dobromir-hristov - please, check if everything works now. Feel free to reopen this ticket.