Implicit fallthroughs

[r-barnes]

Are these implicit fallthroughs intentional? If so, can we mark them with [[fallthrough]]?

kaldi/src/nnet/nnet-convolutional-component.h

Line 157 in 122a3f2

default: end_loop = true;

kaldi/src/nnet/nnet-sentence-averaging-component.h

Line 100 in 122a3f2

default:

[kkm000]

Yes. In both cases, we've just read the closing token <!EndOfComponent> and are falling through the default case, or didn't read any tokens at all, and breaking the loop at the first iteration.

[[fallthrough]] would be nice indeed. I guess the C++17 compiler yells at you? A C++14-compatible alternative is to repeat end_loop = true; and have the case end with the break;

@jtrmal, @danpovey, we are C++17 by default now, ain't we? No longer C++14? I can't think of a compiler that wouldn't C++17 these days.