Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment anchors, etc. should not be marked as external. #22

Open
jdpage opened this issue Dec 18, 2015 · 1 comment
Open

Fragment anchors, etc. should not be marked as external. #22

jdpage opened this issue Dec 18, 2015 · 1 comment
Assignees
@jdpage
Labels
bug markup
Milestone
0.1 Aromaticity

Comments

@jdpage
Copy link
Owner

jdpage commented Dec 18, 2015

Right now, only numeric links and title links are marked as internal. In general, links that don't link outside of the site, or at least don't link outside of the wiki root, should be marked as internal.
@jdpage jdpage mentioned this issue Dec 18, 2015
Closed
@jdpage jdpage added this to the 0.1 Aromatic milestone Dec 22, 2015
@jdpage jdpage self-assigned this Dec 28, 2015
@jdpage jdpage changed the title Fragment anchors should not be marked as external. Fragment anchors, etc. should not be marked as external. Dec 31, 2015
@jdpage
Copy link
Owner Author

jdpage commented Dec 31, 2015

As noted by @woodrowbarlow, pages which are trying to be internal links but wouldn't be valid pages should not be marked as "external" links. (They should probably just be passed through.)

This was referenced Jan 9, 2016
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdpage jdpage

Labels
bug markup
Projects
None yet
Milestone
0.1 Aromaticity
Development

No branches or pull requests
1 participant
@jdpage