Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-clicking a word before an inline element and deleting crashes Slate (Windows/Chrome) #5690

Open
tamsingreen opened this issue Aug 1, 2024 · 1 comment

Comments

@tamsingreen
Copy link

Description
In Chrome, double-clicking a word on Windows before an inline element and pressing backspace causes Slate to crash with the error

Recording
https://github.com/user-attachments/assets/8426b849-86d2-4f5c-9514-608ab33b3e02

Steps
To reproduce the behavior:

  1. Go to Slate examples - inline in Chrome on Windows
  2. Double-click on 'a' before the 'hyperlink' inline element, 'a ' (a, space) is selected
  3. Press backspace
  4. View console to see error Failed to execute 'setEnd' on 'Range': There is no child at offset 66

Expectation
The selected text 'a ' is deleted.

Environment

  • Slate Version: 0.103
  • Operating System: Windows
  • Browser: Chrome
@tamsingreen
Copy link
Author

This appears to have been resolved in our codebase by removing the <InlineChromiumBugFix /> as documented here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant