Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember3 upgrade - ran into issue with scheduler never exiting #5

Closed
josh803316 opened this issue Mar 21, 2018 · 1 comment
Closed

Ember3 upgrade - ran into issue with scheduler never exiting #5

josh803316 opened this issue Mar 21, 2018 · 1 comment

Comments

@josh803316
Copy link

I have upgraded a component library to Ember3 which is using "@html-next/vertical-collection": "1.0.0-beta.10" for one of our grids. I noticed after I upgraded, during the test for that grid, that the scheduler seems to be stuck with in a never ending loop.

function registerWaiter() {
    // We can't rely on the importable Ember since shims are no
    // longer included by default, so use the global instance.
    // eslint-disable-next-line
    Ember.Test.registerWaiter(function () {
      return _emberRafScheduler.default.jobs === 0;  // THIS value is stuck at 1
    });
  }

tests/test_helpers.js

import Application from '../app';
import registerWaiter from 'ember-raf-scheduler/test-support/register-waiter';
import config from '../config/environment';
import { setApplication } from '@ember/test-helpers';

import resolver from './helpers/resolver';
import { setResolver } from '@ember/test-helpers';
import { start } from 'ember-qunit';

setResolver(resolver);

registerWaiter();

setApplication(Application.create(config.APP));
start();

I also saw a separate test fail that was passing with:
Tried to restart test while already started (test's semaphore was 0 already)
but I wasn't sure if it was related.

Any guidance would be appreciated.

@mixonic
Copy link
Contributor

mixonic commented Apr 10, 2023

Closing this, as I think html-next/vertical-collection#320 triaged this to a more narrow root cause (multiple v-c instance with the same container selector).

Please feel free to re-open, especially if there is an issue reproducible with the latest release. Generally, that release is widely used with Ember 3 and 4.

@mixonic mixonic closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants