Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused logging code #1470

Open
schneems opened this issue Jun 20, 2024 · 0 comments
Open

Remove unused logging code #1470

schneems opened this issue Jun 20, 2024 · 0 comments

Comments

@schneems
Copy link
Contributor

From #1469 (comment), it was brought up that I removed a logging call and didn't replace it. This logging functionality is not being used, so it's presence is causing confusion and it adds no value.

We should:

  • Remove all calls to log() in the codebase
  • Remove log function
  • Remove the internals that only log uses, such as log_internal
  • Do an audit to see if any other functionality to support logging is no longer used by any other codepaths, for example the value set here@id = Digest::SHA1.hexdigest("#{Time.now.to_f}-#{rand(1000000)}")[0..10] is being consumed by the logger. If it's not being used anywhere else we can get rid of it.

We need to take care to not break builds. We have a lot of integration tests, but they're not comprehensive. A one-in-a-million occurrence happens pretty frequently around here. Ruby does not give strong static guarantees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant