Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needless warnings about too up-to-date deps during pip installs #382

Open
janosh opened this issue Apr 16, 2021 · 3 comments
Open

Needless warnings about too up-to-date deps during pip installs #382

janosh opened this issue Apr 16, 2021 · 3 comments

Comments

@janosh
Copy link
Member

janosh commented Apr 16, 2021

automatminer causes needless recurring warnings when updating packages it depends on:

pip install crystal-toolkit

[...]

automatminer 1.0.3.20200727 requires matminer==0.6.2, but you'll have matminer 0.6.5 which is incompatible.
automatminer 1.0.3.20200727 requires pymatgen==2020.01.28, but you'll have pymatgen 2022.0.5 which is incompatible.
automatminer 1.0.3.20200727 requires scikit-learn==0.22.2, but you'll have scikit-learn 0.24.1 which is incompatible.

I believe the way to fix this is to simply specify dependencies with >= rather than == in requirements.txt. Will submit PR.

@ardunn
Copy link
Contributor

ardunn commented May 6, 2021

Hey @janosh thanks for reporting the issue!

I will update the dependencies soon (hopefully resolving some of the incompatibilities) but I am a big weary about changing everything to >=. I have not tested it yet but I suspect that will break some things. Considering the large number of things automatminer does in a pipeline (many of which rely on a lot of different libraries) it seems like this could cause some instability. But if you have a PR with the updated requirements that passes CI and is relatively stable, I'm all ears!!

@janosh
Copy link
Member Author

janosh commented May 7, 2021

I will update the dependencies soon [...]

Good to know. In that case feel free to close my PR.

@shyamd
Copy link

shyamd commented Jul 11, 2021

You should test against pinned versions in requirements.txt, but have compatible version ranges in setup.py where you can use both >= and < to ensure you have compatible versions ranges. This is causing problems in the MP Workshop repo for auto-updates for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants