Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buggy installation on npm>=8 #1153

Closed
3y3 opened this issue Nov 22, 2023 · 5 comments
Closed

Buggy installation on npm>=8 #1153

3y3 opened this issue Nov 22, 2023 · 5 comments

Comments

@3y3
Copy link
Contributor

3y3 commented Nov 22, 2023

uikit depends on unsupported package react-sortable-hoc

There was some collisions in dependency tree resolving for react version.

This troubles to npm/cli#4631

Possible solution:
Fork react-sortable-hoc,
merge this pr clauderic/react-sortable-hoc#844
release @gravity-ui/react-sortable-hoc

@korvin89
Copy link
Contributor

@ValeraS @amje What do u think about fork?

@ValeraS
Copy link
Contributor

ValeraS commented Nov 22, 2023

Seems, it's npm only issue, and can be solved by using overrides inside your project's package.json.

@3y3
Copy link
Contributor Author

3y3 commented Nov 22, 2023

No way.
We use uikit within @diplodoc/cli.
There is a possibility, though, where this cli is installed in an empty directory that does not have a package.json file.

@melikhov-dev
Copy link
Contributor

Ok, react-sortable-hoc is deprecated and does not support React 18.

If we want support React 18, we need to replace this with a modern library. Or we need to say that uikit does not support React 18.

@amje amje closed this as completed Dec 4, 2023
@amje
Copy link
Contributor

amje commented Dec 4, 2023

#1159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants