Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $SENTRY_SPOTLIGHT env var support to all SDKs #482

Open
3 of 12 tasks
BYK opened this issue Aug 8, 2024 · 0 comments
Open
3 of 12 tasks

Add $SENTRY_SPOTLIGHT env var support to all SDKs #482

BYK opened this issue Aug 8, 2024 · 0 comments
Assignees
@BYK
Labels
Type: Enhancement New feature or request

Comments

@BYK
Copy link
Member

BYK commented Aug 8, 2024 •
edited
Loading

Persona: you are a person who's new to a code base, trying to understand how everything works together.

Assumption: It's a challenge to find all the places Sentry SDKs are initialized let alone change them conditionally for Spotlight (spotlight: true only in dev mode).

Solution: If you can just export $SENTRY_SPOTLIGHT=1 in your shell and run all the services, all applicable Sentry SDKs automatically get set up for Spotlight and you can use the "external" UI (electron or dedicated web UI)

Most popular SDKs so far:

  • JavaScript
  • Python
  • React Native
  • Java
  • Ruby
  • Android
  • Cocoa
  • Golang
  • .NET
  • Dart
  • PHP (Laravel)

Side quest

  • Explore the usage of $SENTRY_DSN in existing SDK setups which should let us use the Spotlight DSN hack easily for SDKs not natively supporting Spotlight.
@BYK BYK added the Type: Enhancement New feature or request label Aug 8, 2024
@BYK BYK self-assigned this Aug 8, 2024
This was referenced Aug 13, 2024
Merged
Merged
BYK pushed a commit to BYK/sentry-ruby that referenced this issue Aug 15, 2024
feat: Add support for $SENTRY_DEBUG and $SENTRY_SPOTLIGHT
a9334bf 
Part of getsentry/spotlight#482. Similar to sentry-python#3443 but it also adds support for `$SENTRY_DEBUG` which was lacking in the Ruby SDK.
@BYK BYK mentioned this issue Aug 15, 2024
Merged
sl0thentr0py added a commit to getsentry/sentry-ruby that referenced this issue Aug 16, 2024
@BYK @sl0thentr0py
feat: Add support for $SENTRY_DEBUG and $SENTRY_SPOTLIGHT (#2374)
22f2a3a 
* feat: Add support for $SENTRY_DEBUG and $SENTRY_SPOTLIGHT

Part of getsentry/spotlight#482. Similar to sentry-python#3443 but it also adds support for `$SENTRY_DEBUG` which was lacking in the Ruby SDK.

* rubocop power!

* add changelog entry

* changelog with pr ref

* try again

* now?

* maybe now?

* fix typo

* default to false rather than nil

* use `self.` instead of module name

Co-authored-by: Neel Shah <[email protected]>

* add tests

---------

Co-authored-by: Burak Yigit Kaya <[email protected]>
Co-authored-by: Neel Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BYK BYK

Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BYK