Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry Wizard problematic for offline setup #273

Open
dcramer opened this issue Dec 14, 2023 · 8 comments
Open

Sentry Wizard problematic for offline setup #273

dcramer opened this issue Dec 14, 2023 · 8 comments
Labels
Type: Enhancement New feature or request

Comments

@dcramer
Copy link
Member

dcramer commented Dec 14, 2023

The wizard expects to fully setup your DSN/account, but Spotlight encourages you to utilize the Sentry SDKs before or without using Sentry in production. This would be fine, except the wizard is now the recommended way to setup Sentry in certain runtimes, such as Next.js

@smeubank
Copy link
Member

is the goal for such frameworks, that spotlight could be added with the wizard? And the DSN/account is not needed at least locally

@dcramer
Copy link
Member Author

dcramer commented Dec 14, 2023

No - more that we need the Sentry setup to work first, then we add Spotlight from there. You simply dont need the DSN for Spotlight so forcing that is painful for folks wanting to adopt. Its not bad for some stuff, but particularly bad for something ilke Next.js

@Shubhdeep12 Shubhdeep12 added the Type: Enhancement New feature or request label Feb 3, 2024
@Shubhdeep12
Copy link
Collaborator

So, @dcramer, are you suggesting making the step of connecting the account to get the DSN in the wizard optional? And later, an optional step to add Spotlight as well?

@dcramer
Copy link
Member Author

dcramer commented Feb 5, 2024

Yeah you don't need the DSN at all. Its just "how to go to prooduction" => add your DSN and maybe some other things.

This is mostly probleamtic for things where we've prioritzed the wizard for developers, vs the simple manual setup. Next.js is a great example here.

Likely requires the SDK team at Sentry to make changes to get this back on track.

@Shubhdeep12
Copy link
Collaborator

Is there an ongoing active discussion or thread related to this? I'm interested in participating.
I'll also explore the wizard repository for any relevant information.

@Lms24
Copy link
Member

Lms24 commented Feb 6, 2024

Hmm I'm a bit on the fence if the spotlight use case justifies asking all wizard users a question like

"Do you want to set up Sentry for production or (just) for development?"

I think maybe we add a CLI arg to bypass authentication and project selection (which we need to get the DSN and other things) for starters.

Btw, not saying that this can never happen but right now Spotlight is basically the only way how folks could make use of Sentry without a DSN.
Maybe we should prioritize a spotlight wizard instead 🤔

@Shubhdeep12
Copy link
Collaborator

Shubhdeep12 commented Feb 7, 2024

Yes, it would be more logical to have a wizard for Spotlight.
The use case for Spotlight is defined in such a way that Sentry is an integration for it, but not all users may have Sentry.
Even though Sentry is the default integration, most users will be utilizing Spotlight to view traces through the Sentry SDK, but it can be removed from Spotlight depending on different use cases.

@dcramer
Copy link
Member Author

dcramer commented Feb 12, 2024

Hmm I'm a bit on the fence if the spotlight use case justifies asking all wizard users a question like

"Do you want to set up Sentry for production or (just) for development?"

I think maybe we add a CLI arg to bypass authentication and project selection (which we need to get the DSN and other things) for starters.

Btw, not saying that this can never happen but right now Spotlight is basically the only way how folks could make use of Sentry without a DSN. Maybe we should prioritize a spotlight wizard instead 🤔

To me the issue is not that the wizard is a problem, its that we've now prioritized showing the wizard vs showing you how to actually set things up.

Additionally, given Sentry needs you to understand how to disable itself in local dev (e.g. unset the DSN), I still think theres an opp to improve things here and keep that the truth. At that point there's no reason we couldnt literally inject // spotlight: true, // uncomment this to enable Spotlight (https://spotlightjs.com)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants