Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load parameter to capture skipped rows metadata #191

Open
cschloer opened this issue Jun 16, 2020 · 1 comment
Open

Add load parameter to capture skipped rows metadata #191

cschloer opened this issue Jun 16, 2020 · 1 comment

Comments

@cschloer
Copy link
Contributor

Hey,

I understand the point of this feature being outside of the scope of tabulator (frictionlessdata/tabulator-py#331). I think it would be an important feature to implement in load. As proposed above:

It takes in a list of dicts, each dict containing a regular expression string with once captured group, and one string that contains a column name. The regular expression is then compared to each skipped row in the data. A new column is created with the column_name as its name and the value in the capture group as its value.

If you don't think this would be useful for the general DPP/dataflows community, let me know and I can implement it in our own custom load processor.

@roll @akariv

@roll
Copy link
Member

roll commented Jun 21, 2020

@cschloer
Let's discuss on Monday what's the best place we can put it in (PR to dataflows/custom/etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants