Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Journalist Interface: in "All Sources" listing, hide source-level actions when none are selected #6904

Open
cfm opened this issue Aug 2, 2023 · 4 comments · May be fixed by #7176
Open

Journalist Interface: in "All Sources" listing, hide source-level actions when none are selected #6904

cfm opened this issue Aug 2, 2023 · 4 comments · May be fixed by #7176
Labels
journalist interface (JI) UX

Comments

@cfm
Copy link
Member

cfm commented Aug 2, 2023

Description

Anecdotal user feedback: In the "All Sources" listing, it's confusing that the Download Unread and Download buttons are visible and enabled even when no sources are selected. In particular, Download Unread is interpreted as "download everything unread here", but it returns the error:

securedrop/securedrop/journalist_app/col.py

Lines 109 to 110 in 81a3c49

escape(gettext("Nothing Selected")),
escape(gettext("You must select one or more items.")),

Without changing the actual behavior of these actions, an easy fix would be to hide (or even just disable) the source-level actions when no sources are selected.

How will this impact SecureDrop users?

Journalists will better understand what actions are available to them at any given time.

How would this affect SecureDrop's threat model?

No threat-model implications. This would be a minor addition to existing Journalist Interface scripting, which degrades gracefully.

User Stories

As a journalist, I want clearer indications of what actions are available to me at any given time.
@rjbaarsma
Copy link

Hi!
I'd like to work on this issue. I've noticed that if I set the "disabled" property on buttons the graphical behaviour for the buttons doesn't change: the color doesn't change and there's still a :hover effect. It's okay if I change the .css as well as the script?

@cfm
Copy link
Member Author

cfm commented Jun 7, 2024

Thanks for offering to work on this, @rjbaarsma. You're welcome to make changes to the CSS.

Just FYI: As of August 2023, we are deprioritizing work on new features for the SecureDrop server. This change will not be included in the upcoming v2.9, and we'll consider when to release work like this in a future version on a case-by-case basis.

@rjbaarsma rjbaarsma linked a pull request Jun 7, 2024 that will close this issue
Open
7 tasks
@rjbaarsma
Copy link

Thanks for letting me know! I'll look into ways to help with higher priority software after this.

@rocodes
Copy link
Contributor

rocodes commented Jun 7, 2024

Thanks @rjbaarsma! We mention it just so you're not discouraged if your changes don't ship right away, but we appreciate your contibution. :)

For a look at what we're up to right now (mostly focusing on SecureDrop Workstation and SecureDrop Client, you can check out our roadmap: https://github.com/freedomofpress/securedrop/wiki/Development-Roadmap (we are due to add some updates there too)

And if you want to connect with us or join a standup (Mon-Thurs 9am pacific/12pm Eastern), you're welcome to drop by gitter and chat with the team, or leave us a note here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
journalist interface (JI) UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Journalist UI change 6904 rjbaarsma/securedrop
3 participants
@cfm @rjbaarsma @rocodes