Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xff request setting default should be leave #67

Open
jrynyt opened this issue Feb 8, 2018 · 1 comment
Open

xff request setting default should be leave #67

jrynyt opened this issue Feb 8, 2018 · 1 comment
Labels

Comments

@jrynyt
Copy link

jrynyt commented Feb 8, 2018

If you add a request_setting but do not specify an xff parameter, it defaults to append, which actually inserts vcl to change X-Forwarded-For even if your request setting has nothing to do with that. Or if you have multiple request settings, one of which specifies xff, a subsequent request setting that doesn't include xff will override it.

The default should be leave, which does nothing. The fastly API reference does not specify a default: https://docs.fastly.com/api/config#request_settings

@radeksimko radeksimko added the bug label Jan 24, 2019
@sjparkinson
Copy link
Contributor

This is somewhat related to #489, as re-creating the Force TLS setting currently needs a block like:

request_setting {
  name          = "Generated by force TLS and enable HSTS"
  force_ssl     = true
  xff           = ""
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants