warning in package.json during build

[ST-DDT]

There is a warning in the package.json when the code is build using tsup.

• https://github.com/faker-js/faker/actions/runs/10638166909/job/29493558767

Warning: G] The condition "default" here will never be used as it comes after both "import" and "require" [package.json]

    package.json:48:6:
      48 │       "default": "./dist/index.js"
         ╵       ~~~~~~~~~

  The "import" condition comes earlier and will be used for all "import" statements:

    package.json:46:6:
      46 │       "import": "./dist/index.js",
         ╵       ~~~~~~~~

  The "require" condition comes earlier and will be used for all "require" calls:

    package.json:47:6:
      47 │       "require": "./dist/index.cjs",
         ╵       ~~~~~~~~~

Warning: G] The condition "default" here will never be used as it comes after both "import" and "require" [package.json]

    package.json:54:6:
      54 │       "default": "./dist/locale/*.js"
         ╵       ~~~~~~~~~

  The "import" condition comes earlier and will be used for all "import" statements:

    package.json:52:6:
      52 │       "import": "./dist/locale/*.js",
         ╵       ~~~~~~~~

  The "require" condition comes earlier and will be used for all "require" calls:

    package.json:53:6:
      53 │       "require": "./dist/locale/*.cjs",
         ╵       ~~~~~~~~~

Related code:

faker/package.json

Lines 44 to 49 in 17f570e

	".": {
	"types": "./dist/types/index.d.ts",
	"import": "./dist/index.js",
	"require": "./dist/index.cjs",
	"default": "./dist/index.js"
	},

faker/package.json

Lines 50 to 55 in 17f570e

	"./locale/*": {
	"types": "./dist/types/locale/*.d.ts",
	"import": "./dist/locale/*.js",
	"require": "./dist/locale/*.cjs",
	"default": "./dist/locale/*.js"
	},

[Shinigami92]

We should be a bit careful about this.
https://nodejs.org/api/packages.html#conditional-exports is showing that there are other environments like "node". I also heard once about "browser" to be a thing.

So if this warning is really by tsup, it might not be fully true 🤔

Edit: Or in other words: please double check if we can safely rewrite this

Edit 2 / Afterthoughts: maybe there is an option to suppress this warning? Or it will be gone in v10 when we only support esm only 🤔

[ST-DDT]

Or is this sometging that we have to report to/ask tsup?

[Shinigami92]

There is already an open issue in esbuild evanw/esbuild#3887

• Incorrect warning regarding "default" conditional export evanw/esbuild#3887