{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":540915415,"defaultBranch":"main","name":"buck2-prelude","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-09-24T17:42:55.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1699867592.0","currentOid":""},"activityList":{"items":[{"before":"4c2eac9bb764dae45d46261d4bd362672d601a31","after":"e3baacd2bb760fd10ef78dbfe7e49828ae642e88","ref":"refs/heads/main","pushedAt":"2024-09-19T20:29:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Download BTA patch with changed error message configuration\n\nSummary:\n[Doc](https://docs.google.com/document/d/1-zhGPkmt3I2os-kcIaFk9SvT6odt2AJWswSY-J_6AWs/edit?usp=sharing)\n\n### Context\nWe are exploring the integration of the Kotlin Incremental Compiler into Buck for the incremental compilation of Kotlin source files. The goal is to improve build speed by only recompiling modified source files within a target, rather than rebuilding the entire target as is currently done.\n\n### Problem\nThe BuildToolsApi, an API for integration with the incremental compiler, has been enabled by default. However, there have been reports of a reduced error message ([post](https://l.facebook.com/l.php?u=https%3A%2F%2Ffb.workplace.com%2Fgroups%2F2222954841208728%2Fpermalink%2F2762075557296651%2F&h=AT1cbd2y9NZns-25gkoY4qiqHfxP-p2AW6s50DCdEGizxfR0lrRj3_0csuRn0ddRUlTN9OOUcKl_JbJvyUHN5aHLZytn78ViMZE-de6Q6f3sv8kQU8XyhNt-BJYsd2i__E7Cc_K_Apdz2PoZU8nT06CG)).\n\n### Solution\nThe new format of the error message was a result of a hardcoded implementation of MessageRender in [KotlinLoggerMessageCollectorAdapter](https://github.com/JetBrains/kotlin/blob/6d3dfd265a7e589859f339aa2e553e0a5aca7ccc/compiler/build-tools/kotlin-build-tools-impl/src/main/kotlin/org/jetbrains/kotlin/buildtools/internal/KotlinLoggerMessageCollectorAdapter.kt#L15). In contrast, the default implementation using K2JVMCompiler selects the implementation based on the system configuration [[code pointer](https://github.com/JetBrains/kotlin/blob/6d3dfd265a7e589859f339aa2e553e0a5aca7ccc/compiler/cli/src/org/jetbrains/kotlin/cli/common/CLICompiler.kt#L357)]. In our case, this differs from the one used in BuildToolsApi.\n\nThe configuration was changed in D62971026 and Youtrack task was created [KT-71588](https://youtrack.jetbrains.com/issue/KT-71588/BTA-KotlinLoggerMessageCollectorAdapter-Flexible-MessageRenderer-Implementation).\n\n### This diff\nDownloads a patched version of BuildToolsApi and removes the forked error message for Kosabi, as there is now only one version of the message.\n\nReviewed By: hick209\n\nDifferential Revision: D63028472\n\nfbshipit-source-id: 6bd0e7b53f0088c420ed7ed4f62f9b67fca1fb38","shortMessageHtmlLink":"Download BTA patch with changed error message configuration"}},{"before":"9c0e716fee793cdbd4095de513f1cb46d5c6a9dd","after":"4c2eac9bb764dae45d46261d4bd362672d601a31","ref":"refs/heads/main","pushedAt":"2024-09-19T17:10:49.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Re-order inputs for binary size\n\nSummary:\nThe linker loads the minimal set of object files to satisfy all symbol references. Depending on the order we feed our inputs, we may end up loading more object files than necessary. This diff modifies the dthin-lto bzl logic to order the inputs specifically to minimize loading. This will be closer to what local thin-lto does.\n\nThe new input ordering is as follows:\n\n(1) Force loaded static libraries\n(2) Object files\n(3) Dynamic libraries\n(4) Regular static libraries\n\nThe rationale is as follows. You want to load the objects the linker must load first, that way you don't load an optional object file to provide a symbol which a force loaded object file would've later provided. Next, we list dynamic libraries before any regular static archives. This is so that as many symbols as possible will be pulled from shared libraries instead of duplicated between binaries depending on the shared library (I'm not actually 100% this is how the symbol resolution rules work for dynamic libraries, but that is my guess). Finally we list the regular static libraries (lazy object files) that will only be loaded if absolutely necessary.\n\nThis will reduce binary size, but it should also improve build speed as we load and have to optimize + codegen fewer bitcode files.\n\nReviewed By: rmaz\n\nDifferential Revision: D62991973\n\nfbshipit-source-id: 2c61c2d21bdaa4b3b8f4987d19fccc410637ad42","shortMessageHtmlLink":"Re-order inputs for binary size"}},{"before":"ea3e99bf5f8503b9ada5cb345b9f987b662d5c02","after":"9c0e716fee793cdbd4095de513f1cb46d5c6a9dd","ref":"refs/heads/main","pushedAt":"2024-09-19T16:19:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Passthrough unstripped_native_libraries in apk_genrule attempt #2\n\nSummary:\nThis makes lives easier by not needing to passthrough it.\nOriginal diff D62916369\nLanded the wrong version, :(\n\nReviewed By: IanChilds\n\nDifferential Revision: D62984484\n\nfbshipit-source-id: 0805c94e694a722edd13e9b91cc73bad8c11e2b7","shortMessageHtmlLink":"Passthrough unstripped_native_libraries in apk_genrule attempt <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1385139599\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/buck2-prelude/issues/2\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/buck2-prelude/pull/2/hovercard\" href=\"https://github.com/facebook/buck2-prelude/pull/2\">#2</a>"}},{"before":"e6c9982f166ffef37976abfb058a91fc623706b0","after":"ea3e99bf5f8503b9ada5cb345b9f987b662d5c02","ref":"refs/heads/main","pushedAt":"2024-09-19T13:22:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Delete cgo_library rule from prelude\n\nSummary: It's replaced by `go_library`\n\nReviewed By: echistyakov\n\nDifferential Revision: D62980942\n\nfbshipit-source-id: 0e6476fe5092f060d6d14b6434d95e70753791e5","shortMessageHtmlLink":"Delete cgo_library rule from prelude"}},{"before":"c0597e22a363cc8b1421ba3ac279131402d1fdeb","after":"e6c9982f166ffef37976abfb058a91fc623706b0","ref":"refs/heads/main","pushedAt":"2024-09-19T08:40:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add test host app transition marker\n\nSummary:\nIf `embed_xctest_frameworks_in_test_host_app` is set on an `apple_test()`, the `config//marker/apple/constraints:embed_xctest_frameworks_enabled` constraint is then added to the `test_host_app` via a transition.\n\nThis constraint is then used in `apple_bundle()` to embed XCTest frameworks.\n\nReviewed By: manicaesar\n\nDifferential Revision: D62936576\n\nfbshipit-source-id: 62f95834503eee2dfac8ec71286b0f54c4dd5293","shortMessageHtmlLink":"Add test host app transition marker"}},{"before":"db01dbfc39f40ae658c05b8bb17cc598f30b605c","after":"c0597e22a363cc8b1421ba3ac279131402d1fdeb","ref":"refs/heads/main","pushedAt":"2024-09-19T00:52:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Return the same providers from cgo_library and go_library\n\nReviewed By: echistyakov\n\nDifferential Revision: D62980940\n\nfbshipit-source-id: 42be2a83d3a9d42c6cd44f5a85655b4c4e559a7d","shortMessageHtmlLink":"Return the same providers from cgo_library and go_library"}},{"before":"f0a0dc456606ca64fcbfc523a9482ddaef6e2ac6","after":"db01dbfc39f40ae658c05b8bb17cc598f30b605c","ref":"refs/heads/main","pushedAt":"2024-09-19T00:42:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Automatically determine linkable symbol no-std support\n\nReviewed By: JakobDegen\n\nDifferential Revision: D62997095\n\nfbshipit-source-id: e030eda2f6f548ecd342defc31c751d4a46244b1","shortMessageHtmlLink":"Automatically determine linkable symbol no-std support"}},{"before":"a36871d8230f00d3fb0f59eee3f580eebe107a82","after":"f0a0dc456606ca64fcbfc523a9482ddaef6e2ac6","ref":"refs/heads/main","pushedAt":"2024-09-18T23:45:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Ensure expanded targets are sorted\n\nSummary: Fixup test breakage from D62891027.\n\nReviewed By: dtolnay\n\nDifferential Revision: D62992699\n\nfbshipit-source-id: b937dc3db7bd3f16c0d087f8e64dd28a96350973","shortMessageHtmlLink":"Ensure expanded targets are sorted"}},{"before":"a28dbe2686495ad54e7405d1f6af8fc195961a6f","after":"a36871d8230f00d3fb0f59eee3f580eebe107a82","ref":"refs/heads/main","pushedAt":"2024-09-18T22:03:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"buck2/cxx: include `-dD` option when generating preprocessed output\n\nSummary:\nThis includes all the `#define` directives as well as the preprocessed\noutput, which makes it easier to see where definitions are coming from.\n\nReviewed By: dtolnay\n\nDifferential Revision: D62980081\n\nfbshipit-source-id: f5c3f63761a768d6a09b300603714a6a926cb184","shortMessageHtmlLink":"buck2/cxx: include <code>-dD</code> option when generating preprocessed output"}},{"before":"648f8969bf26075c61558727438743954b0c69c7","after":"a28dbe2686495ad54e7405d1f6af8fc195961a6f","ref":"refs/heads/main","pushedAt":"2024-09-18T21:53:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"linkable symbol: Make open source friendly\n\nSummary:\nWithout advanced_unstable_linking, the addition of `no_std` here is a problem since we end up trying to build the `symbol` library into a staticlib without any panic handler around.\n\nLet people opt out of that.\n\nReviewed By: dtolnay\n\nDifferential Revision: D62925136\n\nfbshipit-source-id: 062d8864e402d1672606709cc354867a64c0e07b","shortMessageHtmlLink":"linkable symbol: Make open source friendly"}},{"before":"e1b0ea11d890e4c465696699932f62090ddb8f89","after":"648f8969bf26075c61558727438743954b0c69c7","ref":"refs/heads/main","pushedAt":"2024-09-18T20:11:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert D62916369: Passthrough unstripped_native_libraries in apk_genrule\n\nDifferential Revision:\nD62916369\n\nOriginal commit changeset: 41f69613c203\n\nOriginal Phabricator Diff: D62916369\n\nfbshipit-source-id: 1688ab7fe07998cea216ddf6665b16ed24abc581","shortMessageHtmlLink":"Revert D62916369: Passthrough unstripped_native_libraries in apk_genrule"}},{"before":"e50861f2dce2ba72e4955d1733fd275580e12bdf","after":"e1b0ea11d890e4c465696699932f62090ddb8f89","ref":"refs/heads/main","pushedAt":"2024-09-18T19:41:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Passthrough unstripped_native_libraries in apk_genrule\n\nSummary: This makes lives easier by not needing to passthrough it.\n\nReviewed By: IanChilds\n\nDifferential Revision: D62916369\n\nfbshipit-source-id: 41f69613c203696d5d1e29727e80671c4118033f","shortMessageHtmlLink":"Passthrough unstripped_native_libraries in apk_genrule"}},{"before":"2a2f608a5c6f077284c2e1a1551dcd0b89d655fa","after":"e50861f2dce2ba72e4955d1733fd275580e12bdf","ref":"refs/heads/main","pushedAt":"2024-09-18T19:36:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert D62910495: Don't cquery deps when expanding proc macros\n\nDifferential Revision:\nD62910495\n\nOriginal commit changeset: bb6eac680e7f\n\nOriginal Phabricator Diff: D62910495\n\nfbshipit-source-id: 2d49d04f91cb82720b6f64080ab21c0650ee98f0","shortMessageHtmlLink":"Revert D62910495: Don't cquery deps when expanding proc macros"}},{"before":"a558b35607ec8aeb0b2d3392b0b2f1af7ef56631","after":"2a2f608a5c6f077284c2e1a1551dcd0b89d655fa","ref":"refs/heads/main","pushedAt":"2024-09-18T19:05:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Replace cgo_library with go_library\n\nSummary: That makes `cgo_library` rule unused and enables us to remove it in a followup diff\n\nReviewed By: echistyakov\n\nDifferential Revision: D62955000\n\nfbshipit-source-id: 8d1660c11bbb47467b7bc812082ad6279f38b838","shortMessageHtmlLink":"Replace cgo_library with go_library"}},{"before":"53af8c0690b389e9f5d97087ff1723857d4996c2","after":"a558b35607ec8aeb0b2d3392b0b2f1af7ef56631","ref":"refs/heads/main","pushedAt":"2024-09-18T14:39:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"avoid using escript for the test binary and use correct toolchain for the test runner\n\nSummary:\nThis change does the following:\n- avoid using escript (its slow and unnecessary)\n- use the correct beam files transitively for the test runnner\n\nThis allows us to run tests using the correct toolchain when we manually overwrite it. It also speeds up running tests a bit.\n\nReviewed By: jcpetruzza\n\nDifferential Revision: D62954867\n\nfbshipit-source-id: 0f839e6dd4f1ff2108362a020ff5f36c1251e767","shortMessageHtmlLink":"avoid using escript for the test binary and use correct toolchain for…"}},{"before":"53d34e81a147f75f99e4aee56ac0ef0bc08b1385","after":"53af8c0690b389e9f5d97087ff1723857d4996c2","ref":"refs/heads/main","pushedAt":"2024-09-18T14:05:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix configured targets to 8.8.3\n\nSummary:\nThis is needed because `hs-ide` can only load binaries compiled by the same version of ghc used to build `hs-ide` itself. Since we currently build `hs-ide` with 8.8.3, let's override the configured targets toolchain selection to ensure it is the 8.8.3 one\n\nThe main downside with this approach is that bootup times will increase, as `hs-ide` needs to wait for Buck to build the dependencies and using a different toolchain means that those won't be warm in the cache thanks to CI.\n\nEventually we should migrate `hs-ide` to GHC 9.2.x in order to take advantage of bugfixes and other improvements to ghcide\n\nReviewed By: simonmar\n\nDifferential Revision: D62936849\n\nfbshipit-source-id: fbb91857a631daa871010e9cbc284dd118a1aea1","shortMessageHtmlLink":"fix configured targets to 8.8.3"}},{"before":"6473cf5de711728029ca345e3f5c3240a8ede8d8","after":"53d34e81a147f75f99e4aee56ac0ef0bc08b1385","ref":"refs/heads/main","pushedAt":"2024-09-18T11:59:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Set link_style at one place for all rules\n\nReviewed By: JakobDegen\n\nDifferential Revision: D62877084\n\nfbshipit-source-id: 77990b5f3d35363bbde93045e56d9c9119ee8dfa","shortMessageHtmlLink":"Set link_style at one place for all rules"}},{"before":"186b0bbe3e9594a2bce579cced2ac01b936b9cdb","after":"6473cf5de711728029ca345e3f5c3240a8ede8d8","ref":"refs/heads/main","pushedAt":"2024-09-18T09:42:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add cxx_universal_executable() stub rule\n\nSummary: Introduces a `cxx_universal_executable()` stub rule. Intended to provide universal binary production for `cxx_`-like rules without the need for having an `apple_toolchain()`.\n\nReviewed By: rmaz\n\nDifferential Revision: D62853243\n\nfbshipit-source-id: 14e0f793dafdaf933f5b51d353d4dff8102d9548","shortMessageHtmlLink":"Add cxx_universal_executable() stub rule"}},{"before":"ff8d00e35dd504e961c3780c7c36ae14738bc931","after":"186b0bbe3e9594a2bce579cced2ac01b936b9cdb","ref":"refs/heads/main","pushedAt":"2024-09-18T03:11:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Don't cquery deps when expanding proc macros\n\nSummary:\nThe final remaining place where we are using `cquery deps` in rust-project.  This fix appears to address issues reported in\n\nhttps://fb.workplace.com/groups/rust.analyzer/posts/1241785263858279\n\nand\n\nhttps://fb.workplace.com/groups/rust.analyzer/posts/1278429846860487\n\nReviewed By: dtolnay\n\nDifferential Revision: D62910495\n\nfbshipit-source-id: bb6eac680e7fd67d4e0c6c15835e09b602635d42","shortMessageHtmlLink":"Don't cquery deps when expanding proc macros"}},{"before":"a1aae29898bbed127d7fb670ca1579529d92fd4f","after":"ff8d00e35dd504e961c3780c7c36ae14738bc931","ref":"refs/heads/main","pushedAt":"2024-09-17T19:49:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove superfluous buck.deps key from bxl\n\nSummary: This is now unused - delete!\n\nReviewed By: dtolnay\n\nDifferential Revision: D62884839\n\nfbshipit-source-id: e75dabd46e8a505912200e3a2c8984f639f9c6b1","shortMessageHtmlLink":"Remove superfluous buck.deps key from bxl"}},{"before":"a8b6276227f17af8eb543d1711a0c74ff85be2a8","after":"a1aae29898bbed127d7fb670ca1579529d92fd4f","ref":"refs/heads/main","pushedAt":"2024-09-17T19:28:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix incorrect build tags handling\n\nSummary:\nThe error\n```\nError running analysis for `fbcode//ligen/tests:buck_test_go_serialized (cfg:linux-x86_64-fbcode-platform010-clang17-asan#cbd32085a595dd73)`\n\nCaused by:\n    0: Error running analysis for `fbcode//ligen/tests:buck_test_go_serialized (cfg:linux-x86_64-fbcode-platform010-clang17-asan#f8ccfa5cb73abfe9)`\n    1: Traceback (most recent call last):\n         File <builtin>, in <module>\n         * fbcode/buck2/prelude/rules.bzl:104, in buck2_compatibility_shim\n             return impl(ctx)\n         * fbcode/buck2/prelude/go/go_test.bzl:110, in go_test_impl\n             main, _ = build_package(ctx, \"main\", [gen_main], package_root = \"\", pkgs = pk...\n         * fbcode/buck2/prelude/go/package_builder.bzl:49, in build_package\n             go_list_out = go_list(ctx, pkg_name, srcs, package_root, tags, cgo_enabled, w...\n         * fbcode/buck2/prelude/go/go_list.bzl:47, in go_list\n             tags.append(\"asan\")\n       error: Immutable\n         --> fbcode/buck2/prelude/go/go_list.bzl:47:9\n```\n\nReviewed By: prakashgayasen\n\nDifferential Revision: D62887073\n\nfbshipit-source-id: 22ee30a8e48f73c4074f8032c56f64532060a586","shortMessageHtmlLink":"Fix incorrect build tags handling"}},{"before":"cafb81da37cc3444c225fb28da0b8428fe84e2ea","after":"a8b6276227f17af8eb543d1711a0c74ff85be2a8","ref":"refs/heads/main","pushedAt":"2024-09-17T19:17:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove protobuf special-cased handling\n\nSummary:\nDepends on MSDK bump from D62849319.\n\nNow that we properly handle OUT_DIR, we don't need to do anything special on our end to handle it.\n\nReviewed By: davidbarsky\n\nDifferential Revision: D62849943\n\nfbshipit-source-id: eacd2af858d79badefa80e6173be627186d8296b","shortMessageHtmlLink":"Remove protobuf special-cased handling"}},{"before":"bd961d004d92f38cbf78a67dd203e8a7c4b1197e","after":"cafb81da37cc3444c225fb28da0b8428fe84e2ea","ref":"refs/heads/main","pushedAt":"2024-09-17T16:53:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Support fallback config when .pc file isn't available\n\nSummary:\nNot all distros (namely ubuntu) publish .pc files for their header packages.\nThis means that `pkg-config --libs <name>` fails, even though the headers are\navilable.\n\nWith this change, if `pkg-config` doesn't recognize the name, it can\npotentially fallback to a hardcoded value. It isn't perfect, but gets ubuntu\nbuilds to parity with fedora.\n\nReviewed By: bigfootjon\n\nDifferential Revision: D62789099\n\nfbshipit-source-id: 815ef0f978516c1b5079cf75fad71fdf03f34de2","shortMessageHtmlLink":"Support fallback config when .pc file isn't available"}},{"before":"03c7ddbd5599f585f4caa60e6d5dca82a6ffc3bd","after":"bd961d004d92f38cbf78a67dd203e8a7c4b1197e","ref":"refs/heads/main","pushedAt":"2024-09-17T16:00:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Resolve OUT_DIR present in env\n\nSummary:\n```\n+++ /dev/fd/62  2024-09-17 01:45:20.335647690 -0700\n@@ -8484,7 +8484,7 @@\n       \"deps\": [],\n       \"edition\": \"2015\",\n       \"env\": {\n-        \"OUT_DIR\": \"$(location fbsource//third-party/rust:crunchy-0.2.2-build-script-run[out_dir] (fbcode//buck2/platform/execution:linux-x86_64#a32dc125c1d570bc))\"\n+        \"OUT_DIR\": \"/data/sandcastle/boxes/fbsource/buck-out/v2/gen/fbsource/a32dc125c1d570bc/third-party/rust/__crunchy-0.2.2-build-script-run__/OUT_DIR\"\n       },\n       \"features\": [\n         \"default\",\n@@ -9837,7 +9837,7 @@\n       ],\n       \"edition\": null,\n       \"env\": {\n-        \"OUT_DIR\": \"$(location fbsource//xplat/whatsapp/smax/smax_rs/smax_rs_common:smax_rs_common_build_run (cfg:linux-x86_64-fbcode-platform010-clang15-asan-ubsan-dev#b6e7c038c1af5f6a))\"\n+        \"OUT_DIR\": \"/data/sandcastle/boxes/fbsource/buck-out/v2/gen/fbsource/b6e7c038c1af5f6a/xplat/whatsapp/smax/smax_rs/smax_rs_common/__smax_rs_common_build_run__/out\"\n       },\n       \"features\": [],\n       \"in_workspace\": false,\n@@ -9983,7 +9983,7 @@\n       ],\n       \"edition\": null,\n       \"env\": {\n-        \"OUT_DIR\": \"$(location fbsource//xplat/whatsapp/smax/smax_rs/smax_rs_proto:smax_rs_proto_build_run (cfg:linux-x86_64-fbcode-platform010-clang15-asan-ubsan-dev#b6e7c038c1af5f6a))\"\n+        \"OUT_DIR\": \"/data/sandcastle/boxes/fbsource/buck-out/v2/gen/fbsource/b6e7c038c1af5f6a/xplat/whatsapp/smax/smax_rs/smax_rs_proto/__smax_rs_proto_build_run__/out\"\n       },\n       \"features\": [],\n       \"in_workspace\": true,\n```\n\nBefore this change, we were outputting an unresolved string with location macro. Now, we properly resolve it.\n\nThis change allows us to correctly handle `OUT_DIR` in projects like smax_rs, which previously reported a failure when trying to go-to source in vs code.\n\nReviewed By: davidbarsky\n\nDifferential Revision: D62849319\n\nfbshipit-source-id: 661ae84a3bca7410cddffd0d96996c5ab1b8bf5d","shortMessageHtmlLink":"Resolve OUT_DIR present in env"}},{"before":"dfb99ed8f5adebbdec08a865b4b818207fb8e382","after":"03c7ddbd5599f585f4caa60e6d5dca82a6ffc3bd","ref":"refs/heads/main","pushedAt":"2024-09-17T15:34:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Pass use_header_units through cxx_binary\n\nSummary: The line got munched during an unfortunate merge conflict resolution. Should have been part of D62382662.\n\nReviewed By: dmpolukhin\n\nDifferential Revision: D62871355\n\nfbshipit-source-id: e25fc4181c0e3680a910481fb2ef7d4e0111b8cf","shortMessageHtmlLink":"Pass use_header_units through cxx_binary"}},{"before":"a50cc12acdad28f0b9c291261ce4069f9db806de","after":"dfb99ed8f5adebbdec08a865b4b818207fb8e382","ref":"refs/heads/main","pushedAt":"2024-09-17T14:01:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Enable local test execution for iOS\n\nSummary: Currently for iOS, `buck test` will always execute tests in RE. This diff adds options to force local or remote test execution, and adds a new automatic option to select where tests execute based on if local execution is possible. (ie. The user is on a Mac with Xcode installed.)\n\nReviewed By: jbardini\n\nDifferential Revision: D62206858\n\nfbshipit-source-id: 07bf50ec3fb7879489d3e887ce49a25ae0f55b0d","shortMessageHtmlLink":"Enable local test execution for iOS"}},{"before":"912d22af6271f2adffbf2effdb35d4cc7de46b85","after":"a50cc12acdad28f0b9c291261ce4069f9db806de","ref":"refs/heads/main","pushedAt":"2024-09-17T12:45:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Enable CGo for go_library\n\nSummary: This diff enables usage of CGo code in `go_library`, starting from this point the behaviour of `go_library` and `cgo_library` is almost identical and we can start removing `cgo_library` from TARGETS files\n\nReviewed By: awalterschulze\n\nDifferential Revision: D62442305\n\nfbshipit-source-id: 7e85e928919e35576c3a15925ee5b44a26cbb3af","shortMessageHtmlLink":"Enable CGo for go_library"}},{"before":"94d399078632ef09fd3c67c42d7de1d1f19bd4d2","after":"912d22af6271f2adffbf2effdb35d4cc7de46b85","ref":"refs/heads/main","pushedAt":"2024-09-17T10:17:46.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Control optimized link groups via attribute\n\nSummary: Add ability to toggle link groups optimizations externally.\n\nReviewed By: artempyanykh\n\nDifferential Revision: D62487172\n\nfbshipit-source-id: 0aea37cbf7e31bc88df3f36f43a30d3981322e57","shortMessageHtmlLink":"Control optimized link groups via attribute"}},{"before":"ce8248452733098c8fbc5be2ddfe5511ceaa52d0","after":"94d399078632ef09fd3c67c42d7de1d1f19bd4d2","ref":"refs/heads/main","pushedAt":"2024-09-17T09:45:06.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Pass cgo_enabled explicitely via package_builder\n\nSummary:\n- Pass the attribute explicitly as an arg rather than get it from ctx.attrs\n- Set CGO_ENABLED var only when required, i.e. on `go list` and `go build std`\n\nReviewed By: awalterschulze\n\nDifferential Revision: D62743980\n\nfbshipit-source-id: 5bf1167604362bd708f8bba2f32abf79e8ac26ab","shortMessageHtmlLink":"Pass cgo_enabled explicitely via package_builder"}},{"before":"4c74e4f154f5fe302fa6216562ffecd457600d7d","after":"ce8248452733098c8fbc5be2ddfe5511ceaa52d0","ref":"refs/heads/main","pushedAt":"2024-09-17T04:39:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"linkable symbol: Fix autodeps\n\nSummary: If anyone has any better ideas, I'm all ears\n\nReviewed By: dtolnay\n\nDifferential Revision: D62807821\n\nfbshipit-source-id: f13d75f533b136e8ee90616d6bc60e048d11b86c","shortMessageHtmlLink":"linkable symbol: Fix autodeps"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEu0r4PgA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/buck2-prelude"}