Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with mypy typing when importing fideslang #6

Open
NevilleS opened this issue Jan 8, 2024 · 0 comments
Open

issues with mypy typing when importing fideslang #6

NevilleS opened this issue Jan 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@NevilleS
Copy link

NevilleS commented Jan 8, 2024

From fideslang created by adamsachs: IABTechLab#138

Bug Description

Still not 100% sure this is a bug in fideslang, but something seems to have changed with the packaging updates in 1.4.3 that's making our mypy runs in fides complain about our imports of fideslang, if using fideslang>=1.4.3.

We need to get this fixed one way or another (again, the "fix" may turn out to be adjusting something over in the dependent library, e.g. fides!) since it's causing false negatives and CI failures in fides and fidesplus.

Steps to Reproduce

  1. run nox -s mypy in fides (or fidesplus)

Expected behavior

we should be effectively not receiving these errors in our dependent libraries, or we should be effectively suppressing them!

Additional context

This was noticed and discussed first on this draft PR. i figured i'd make a proper ticket out of it now, since it's now causing CI failures on main in both repos.

We can re-ticket over in fides and fidesplus if this is a problem on their side in how they're referencing fideslang now with the new packaging scheme.

@NevilleS NevilleS added the bug Something isn't working label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant