click search result, go to docs/3.0.0

[aladdin-add]

it is expected to open the latest version.

[ilyavolodin]

Yes, I noticed that too. It has something to do with this line: 6d951fd#diff-7693eb643e8fe8b8d46b407909b408ceR31 but I haven't had a chance to dig into DocSearch documentation yet to figure out how to correct it.

[Krinkle]

This is actively causing 404 Not Found errors for users, making it rather difficult to find things.

Example: search for "for-direction" on https://eslint.org/.

Search	Result	404

This claims to be the 3.0.0 rules page, but links to for-direction which was introduced in ESLint 4.

[platinumazure]

I'm looking into this. I think I understand the issue, though I need to confirm a few things before I try to make any changes.

We'll also need to document necessary changes to docsearch configs (in https://github.com/algolia/docsearch-configs) as part of major releases. That will go in the maintainer guide.

Edit: On second thought, if we just don't index documentation from old versions of ESLint, then we wouldn't need to change the major release process. I'm not convinced we need to index old ESLint documentation at this point.

[platinumazure]

I think I have the beginning of a fix lined up:

• Created Update ESLint config (refs eslint/eslint.github.io#475) algolia/docsearch-configs#440 to fix Docsearch crawling configuration
• Created Update: Request docs and blog content in Docsearch #481 to fix our Docsearch client configuration

In the Docsearch PR, I can't start from /docs because that page does not exist in the repo. So I'm starting from /docs/rules, /docs/user-guide, /docs/developer-guide, and /docs/maintainer-guide (all of which should exist). There might be other improvements we could make, but that PR (or something similar) should help fix most of the issues.

[platinumazure]

We've merged the docsearch-configs change and the eslint.github.io change. Unfortunately I didn't think about the fact that the scraper probably hasn't run yet so we have the eslint.github.io changes running against the old index. It will resolve itself after the next scraper run (within 24 hours).

I'll check tomorrow to see how the search experience looks, then either close this issue or open new PRs against this issue as needed.

Apologies for any inconvenience as we're rebuilding our search config.

[platinumazure]

I just checked and things are actually looking consistent-- maybe the index was built after the docsearch-configs changes were merged.

@aladdin-add @Krinkle How does it look on your end?

[Krinkle]

@platinumazure Yep, the search seems to be working well again. Thanks!

I do note that https://eslint.org/docs/3.0.0/rules/ still lists for-direction in the table, linking to a 404 Not Found. I've filed #486 for that.

[platinumazure]

Thanks for confirming @Krinkle.

I'm going to leave this open for a few days in case I want to make any more PRs to tweak the search configuration.

[platinumazure]

I wrote algolia/docsearch-configs#457 to avoid indexing of blog headers, since those are identical in every post.

Closing as the main issue is resolved.