Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching from shaclex to shacl-s #313

Open
berezovskyi opened this issue Apr 20, 2023 · 5 comments
Open

Consider switching from shaclex to shacl-s #313

berezovskyi opened this issue Apr 20, 2023 · 5 comments
Labels

Comments

@berezovskyi
Copy link
Member

According to weso/shaclex#492 (comment)

@jaw111
Copy link

jaw111 commented Feb 20, 2024

Given that Lyo is already dependent on Jena, why not use the Jena SHACL implementation?

https://jena.apache.org/documentation/shacl/

@berezovskyi
Copy link
Member Author

@jaw111 validation library for Lyo was written when Jena had no support for SHACL (ca. in 2017-2018). shacl-s is a dependency of shaclex and the change should be minimal in code change and reduce the number of dependencies. Switching to Jena SHACL library is a good idea but may require more code rewrite. I don't have plans for such rewrite now as I am not really active in Lyo for the time being. If you wish to contribute, please sync with @Jad-el-khoury to make sure no effort is wasted and you have a smooth experience with a first-time contribution.

@jamsden
Copy link
Contributor

jamsden commented Feb 20, 2024

Maybe deprecate using the jaw111 library in favor of SHACL to give time to remove it?

@berezovskyi
Copy link
Member Author

@jamsden, both the current and proposed lyo validation libraries would be based on SHACL. John aka jaw111 was suggesting to switch to Jena all the way and eliminate shaclex to deliver the same SHACL support.

Again, like the idea but don't see myself doing the migration, unfortunately. If I get any spare time these days, I usually spend it on bringing the oslc4net SDK to life.

@Jad-el-khoury
Copy link
Contributor

All contributions are welcome. I have not seen the need for the validation library, and that's why it has not been updated.
But I agree that it would make sense to migrate to Jena's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants