Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate BinaryFormatter Impact On DataSets #11366

Open
lonitra opened this issue May 13, 2024 · 2 comments
Open

Investigate BinaryFormatter Impact On DataSets #11366

lonitra opened this issue May 13, 2024 · 2 comments
Assignees
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization

Comments

@lonitra
Copy link
Member

lonitra commented May 13, 2024

DataSets may be impacted by BinaryFormatter. We need to investigate serialization/deserialization flow for DataSets, understand what impact BinaryFormatter might have, and determine next steps from there.

@lonitra lonitra added untriaged The team needs to look at this issue in the next triage area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization labels May 13, 2024
@kirsan31
Copy link
Contributor

Ilink to my question on this topic: #6267 (comment)

@lonitra lonitra removed the untriaged The team needs to look at this issue in the next triage label May 14, 2024
@eduarddejong
Copy link

eduarddejong commented Jun 6, 2024

This is definitely important to look at, as it plays a role in the ability to port old .NET Framework desktop applications to modern .NET 8 or 9.

See the following issue (I also left a comment personally hoping for more attention to it) created on the Visual Studio Developer Community: https://developercommunity.visualstudio.com/t/MSDataSetGenerator-Generate-SYSLIB0051-w/10488377?q=BinaryFormatter

I don't know how everything internally works with the Typed DataSet designer, but parts of the generated code in the .Designer.cs file are making calls to obsolete StreamingContext constructors.
I believe these code parts should not be a technical requirement for the DataSet it's actual functionality.

In fact the dataset designer is not even a direct WinForms part or even modern .NET, but a Visual Studio component probably still running in old .NET Framework.
But it's the fact that it's all dependently connected to each other in this old type of VS project and that a good working VS solution is also needed to keep it all working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization
Projects
None yet
Development

No branches or pull requests

4 participants