Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Mergeable is green when the PR still requires a review #402

Open
markediez opened this issue Jul 3, 2024 · 0 comments
Open

[BUG] Mergeable is green when the PR still requires a review #402

markediez opened this issue Jul 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@markediez
Copy link

markediez commented Jul 3, 2024

Describe the bug
I have a PR that has no github checks but requires at least 1 review to be merged. gh-dash shows this PR with a green Checks label. This should be red. Would be cool if there was a section that states Requires x reviews maybe under Checks?

To Reproduce
Steps to reproduce the behavior:

  1. Create a pull request that requires 1 reviewer before merging
  2. Open GH dash and hover over your PR
  3. Open the preview with p it should show you that the PR has green Checks label even though it is not

Expected behavior
Checks label for PRs still requiring a review should be red instead of green

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Mac]
@markediez markediez added the bug Something isn't working label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant