Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify/generalise speller/manifest.ts #1

Open
snomos opened this issue May 12, 2023 · 0 comments
Open

Simplify/generalise speller/manifest.ts #1

snomos opened this issue May 12, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@snomos
Copy link
Member

snomos commented May 12, 2023

The function deriveLangTag is using a hard-coded list of languages to be converted from 3-letter to 2-letter codes. This information is already present in configure.ac for all languages, and should be taken from that file.

Since manifest.toml is derived by autoconf from manifest.toml.in, we can just use the variable @GLANG2@. We need to update manifest.toml.in to contain the necessary information, and then update the function to use the new information instead of the hard-coded list.

@GLANG2@ will be 2-letter if available, 3-letter otherwise. It is subject to human errors, though - the information is provided by humans upon repo creation time. The actual risk for error is pretty low, and is easy to correct if it happens.

@snomos snomos added the enhancement New feature or request label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants