Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database host specified in .env for docker container #283

Open
anderscollstrup opened this issue Aug 18, 2022 · 4 comments
Open

database host specified in .env for docker container #283

anderscollstrup opened this issue Aug 18, 2022 · 4 comments
Labels
deployment Related to installation/deployment of 4CAT rather than 4CAT proper docker issue Issue that only occurs when using 4CAT via Docker (mostly) back-end Primarily involves the back-end (e.g. post-processors, scheduler or crawlers). PR-welcome A valid issue, but not a priority - but pull requests would be welcome

Comments

@anderscollstrup
Copy link

Hi,

I want to be able to specify a separate database host in the docker container
/usr/src/app/docker/docker-entrypoint.sh users --host=db
I want to specify a different --host so I can use a database hostet elsewhere.

Root problem
The postgres db container cannot run with Azure Container Instances because of postgres ownership requirements on the storageaccount
Database host is hardcoded in /usr/src/app/docker/docker-entrypoint.sh

It would be nice if our university could offer 4cat as an azure container to researchers and students. But we would like to use a managed postgres service instead of a container. Much cheaper than deploying standalone docker servers.

Regards Anders

@dale-wahl
Copy link
Member

dale-wahl commented Aug 18, 2022

If you want to customize your version for your specific environment, you can certainly do so. The wiki has some steps on how to fairly easily make changes and deploy your own version.

You could link a fork here if you think it will help others. And we of course appreciate PR requests if you make changes that can be optionally used by others! Particularly new datasources and processors!

@anderscollstrup
Copy link
Author

I know I can fork the project, but it will be difficult to maintain. I am not a dev, I don't have automatet pipelines and so on.
I was also thinking that being able to specify database host was a very small change and it could benefit others.

.... what is a PR request?

/Anders

@stijn-uva
Copy link
Member

stijn-uva commented Aug 19, 2022

Hi @anderscollstrup , we are unfortunately not able to invest time in this at the moment as we do not use an infrastructure like the one you describe ourselves so there is no direct benefit for us in supporting this environment, and it would be difficult for us to test. We of course try to make 4CAT as easy to install by others as possible but we are a small team so we have to make choices in that regard.

Of course, if someone else comes along who can make the necessary tweaks to make this configurable we would be happy to integrate those. In that case they can open a Pull Request (PR) with the changes and we can review and integrate them in that way.

In the meantime, you can of course change the database address mentioned in the configuration files manually for your instance of 4CAT.

@stijn-uva stijn-uva added (mostly) back-end Primarily involves the back-end (e.g. post-processors, scheduler or crawlers). deployment Related to installation/deployment of 4CAT rather than 4CAT proper PR-welcome A valid issue, but not a priority - but pull requests would be welcome labels Aug 19, 2022
@anderscollstrup
Copy link
Author

Hi,

I hired someone to make the required changes, I am happy to see that Pull Request are welcome. I guess he already made one :-)

Changes;
master...alk-automize:4cat:master

Fork:
https://github.com/alk-automize/4cat

@stijn-uva stijn-uva added the docker issue Issue that only occurs when using 4CAT via Docker label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Related to installation/deployment of 4CAT rather than 4CAT proper docker issue Issue that only occurs when using 4CAT via Docker (mostly) back-end Primarily involves the back-end (e.g. post-processors, scheduler or crawlers). PR-welcome A valid issue, but not a priority - but pull requests would be welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants