Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Google token exchange/signed URL acquisition more robust #158

Open
athornton opened this issue Apr 11, 2024 · 0 comments
Open

Make Google token exchange/signed URL acquisition more robust #158

athornton opened this issue Apr 11, 2024 · 0 comments

Comments

@athornton
Copy link
Collaborator

After a few months of nightly CI use, we've noticed that occasionally the Workload Identity switcheroo and/or getting a signed URL from the Google Cloud Storage backend fails.

This seems to be fairly infrequent (but more frequent than you'd expect from a Google service) (once or twice a week, and we have overnight CI runs that do git-lfs operations on dozens of repositories) and transient.

I'm creating this issue mostly as a reminder to myself to implement a retry loop inside the relevant bits of the code; it should have no user-visible impact whatsoever except to ameliorate transient git failures (no API changes). I don't think it's much work, and I'll get to it when I have a few hours free to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant