New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log integration polishing #90

Open

2 of 5 tasks

hannelita opened this issue Sep 4, 2020 · 2 comments

Contributor

hannelita commented Sep 4, 2020 •

edited

Loading

Acceptance

Handle large log entries (prevent timeouts)
Handle proper encoding
Integration test (log consumption)

Tasks

Set up a max page size to prevent timeouts (this issue won't implement full pagination, but at least the request won't fail when fetching the logs)
Encode JSON response before calling response.json() on aircan-connector

Analysis

PR datopian/ckanext-aircan#21 was merged and it breaks the filter

Notes

These two features are left out
~~dynamic filters~~
~~Customizable filters~~

The text was updated successfully, but these errors were encountered:

Contributor Author

hannelita commented Sep 18, 2020

See #93 - An integration test would have caught the problem

Contributor Author

hannelita commented Sep 28, 2020

Blocked by #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment