Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIilter datasets by findability on publishers page #225

Open
4 tasks
zelima opened this issue Mar 9, 2018 · 0 comments
Open
4 tasks

FIilter datasets by findability on publishers page #225

zelima opened this issue Mar 9, 2018 · 0 comments
Assignees
Milestone

Comments

@zelima
Copy link
Contributor

zelima commented Mar 9, 2018

Originally coming from here datopian/datahub-qa#154

We need to filter page by findability. Eg I'm interested to see only private datasets of mine

Acceptance Criteria

  • Able to type private and get datasets (maybe like GitHub search?)
  • or alternatively dropdown

Tasks

  • do analysis and decide on solution
  • implement

Analysis

  • We can refactor our search to include switch statement, so it catches the following cases:
    • published - and returns only published
    • private - and returns only private
    • unlisted - and returns only unlisted

Somewhere here https://github.com/datahq/frontend/blob/master/routes/index.js#L1021 we can check query param and add get datasets by findability
We can refactor metastore search https://github.com/datahq/metastore/blob/master/metastore/blueprint.py to search by findability

https://api.datahub.io/metastore/search?q=datahub.ownerid=${ownerid}&token=${jwt}&findability=private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants