Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JsonShapeValidatorMiddleware when validating an API response #4

Open
jkva opened this issue Jun 21, 2022 · 1 comment
Open

Use JsonShapeValidatorMiddleware when validating an API response #4

jkva opened this issue Jun 21, 2022 · 1 comment

Comments

@jkva
Copy link
Collaborator

jkva commented Jun 21, 2022

Currently, API requests are assumed to be valid when returned from the API. Since the JsonShapeValidatorMiddleware is already used to validate webhook update shapes, this should be used as a default middleware within the JsonMapper instance used to parse API request responses.

Related to #3.

@jkva
Copy link
Collaborator Author

jkva commented Jun 29, 2022

There is current code available for that, yet when enabled this triggers a fair amount of validation errors in existing tests which need to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant