Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 504 error page/handling to not dump 3/4mb of content (700k of which is base64 noise) #221

Open
jsoref opened this issue Aug 27, 2024 · 1 comment
Open

Change 504 error page/handling to not dump 3/4mb of content (700k of which is base64 noise) #221

jsoref opened this issue Aug 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jsoref
Copy link

jsoref commented Aug 27, 2024 •
edited
Loading

Please consider changing your 504 error page to not embed 5 woff, 2 eot, and 1 truetype fonts as data: urls. The page is 3/4mb. >1/4mb of that is fonts (plus 250kb for an svg, and another ~75k for two pngs). The entire response is dumped by coverallsapp/github-action@v2 when hit, as in https://github.com/PowerDNS/pdns/actions/runs/10411289118/job/29294135610#step:2:85

While you're fixing the 504 page (by removing the 700kb of noise), could you change it to actually say Five Zero Four -- it might be hard to notice in the noise, but it's a little easier with the noise omitted:

  <body id="errorPage">
    <div class="cf-error-details cf-error-504">
  <h1>Gateway time-out</h1>
  <p>The web server reported a gateway time-out error.</p>
  <ul>
    <li>Ray ID: 8b9a6d7d1fd32ab7</li>
    <li>Your IP address: 20.172.5.45</li>
    <li>Error reference number: 504</li>
    <li>Cloudflare Location: Los Angeles</li>
  </ul>
</div>

...

        <div class="container site-wrapper">
          <h1>
            <img alt="Public_stomp" src="">
            Five Zero Zero
          </h1>
          <div class="alert alert-error">
            <h3>It's Gone Pear Shaped</h3>
            <p>There has been a hiccup, the revolution will continue after we stamp out the refusniks. You could also try refreshing or returning to the home page.</p>
          </div>
@afinetooth
Copy link
Member

@jsoref thanks for the suggestion. I have submitted an engineering ticket for the changes.

@afinetooth afinetooth added the enhancement New feature or request label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afinetooth @jsoref