Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Research installing signal handlers for the interruption flow #651

Open
webknjaz opened this issue Mar 18, 2024 · 0 comments
Open
Labels

Comments

@webknjaz
Copy link
Member

I think that reacting to SIGINT, or SIGBREAK / CTRL_C_EVENT / CTRL_BREAK_EVENT for Windows, would be more predictable than CPython's default handler that throws a KeyboardInterrupt in arbitrary moments in time.
While on it, looking into handling SIGTSTP / SIGCONT could be useful as well.

A related thought: should the server interruption flow raise a CherrotServerInterrupt, inherited from something like InterruptedError (or KeyboardInterrupt)?

Refs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant