You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
β question about the decisions made in the repository
π Describe the bug. What is the current behavior?
If stopped is called on a preparing server, the server won't stop if it's reaches the serve state.
β What is the motivation / use case for changing the behavior?
I need a cheroot server which starts in another thread. Sometime it can happen that a server hangs during the prepare, e.g. due to a socket error. Therefore the "parent" thread will then stop the server and retry later.
π‘ To Reproduce
Of course this will not happen in the real world like this. I used events to showcase the issue in a reproducible way:
β I'm submitting a ...
π Describe the bug. What is the current behavior?
If stopped is called on a preparing server, the server won't stop if it's reaches the serve state.
β What is the motivation / use case for changing the behavior?
I need a cheroot server which starts in another thread. Sometime it can happen that a server hangs during the prepare, e.g. due to a socket error. Therefore the "parent" thread will then stop the server and retry later.
π‘ To Reproduce
Of course this will not happen in the real world like this. I used events to showcase the issue in a reproducible way:
π‘ Expected behavior
When stopped is called, the server stops as soon as possible
π Details
The issue can be also be fixed, by using interrupt instead of stop.
However, the code get's more complicated:
If the last
server.stop
is not used, the program is stucked again. E.g. with py-spy:π Environment
The text was updated successfully, but these errors were encountered: