From ee90a278db919013dfc44c41becc14a74b9de712 Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Mon, 2 Sep 2024 22:27:27 +0100 Subject: [PATCH 1/4] lexicon update for attribution and licenseUri --- lexicons/app/bsky/embed/video.json | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lexicons/app/bsky/embed/video.json b/lexicons/app/bsky/embed/video.json index da58ded8bb4..d035de5fef9 100644 --- a/lexicons/app/bsky/embed/video.json +++ b/lexicons/app/bsky/embed/video.json @@ -26,6 +26,16 @@ "aspectRatio": { "type": "ref", "ref": "app.bsky.embed.defs#aspectRatio" + }, + "attribution": { + "type": "string", + "description": "Attribution for the video, e.g. the creator or source.", + "maxGraphemes": 300, + "maxLength": 3000 + }, + "licenseUri": { + "type": "string", + "format": "uri" } } }, From 103c2d943828a147550e43747af83e22d0436d6f Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Mon, 2 Sep 2024 22:27:48 +0100 Subject: [PATCH 2/4] codegen --- packages/api/src/client/lexicons.ts | 11 +++++++++++ packages/api/src/client/types/app/bsky/embed/video.ts | 3 +++ packages/bsky/src/lexicon/lexicons.ts | 11 +++++++++++ .../bsky/src/lexicon/types/app/bsky/embed/video.ts | 3 +++ packages/ozone/src/lexicon/lexicons.ts | 11 +++++++++++ .../ozone/src/lexicon/types/app/bsky/embed/video.ts | 3 +++ packages/pds/src/lexicon/lexicons.ts | 11 +++++++++++ .../pds/src/lexicon/types/app/bsky/embed/video.ts | 3 +++ 8 files changed, 56 insertions(+) diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts index 5111b619dea..7f03d4e0e0a 100644 --- a/packages/api/src/client/lexicons.ts +++ b/packages/api/src/client/lexicons.ts @@ -5297,6 +5297,17 @@ export const schemaDict = { type: 'ref', ref: 'lex:app.bsky.embed.defs#aspectRatio', }, + attribution: { + type: 'string', + description: + 'Attribution for the video, e.g. the creator or source.', + maxGraphemes: 300, + maxLength: 3000, + }, + licenseUri: { + type: 'string', + format: 'uri', + }, }, }, caption: { diff --git a/packages/api/src/client/types/app/bsky/embed/video.ts b/packages/api/src/client/types/app/bsky/embed/video.ts index 2be451b85ed..bd1841904ef 100644 --- a/packages/api/src/client/types/app/bsky/embed/video.ts +++ b/packages/api/src/client/types/app/bsky/embed/video.ts @@ -13,6 +13,9 @@ export interface Main { /** Alt text description of the video, for accessibility. */ alt?: string aspectRatio?: AppBskyEmbedDefs.AspectRatio + /** Attribution for the video, e.g. the creator or source. */ + attribution?: string + licenseUri?: string [k: string]: unknown } diff --git a/packages/bsky/src/lexicon/lexicons.ts b/packages/bsky/src/lexicon/lexicons.ts index 295d5beccdf..cc1beaf7f24 100644 --- a/packages/bsky/src/lexicon/lexicons.ts +++ b/packages/bsky/src/lexicon/lexicons.ts @@ -5297,6 +5297,17 @@ export const schemaDict = { type: 'ref', ref: 'lex:app.bsky.embed.defs#aspectRatio', }, + attribution: { + type: 'string', + description: + 'Attribution for the video, e.g. the creator or source.', + maxGraphemes: 300, + maxLength: 3000, + }, + licenseUri: { + type: 'string', + format: 'uri', + }, }, }, caption: { diff --git a/packages/bsky/src/lexicon/types/app/bsky/embed/video.ts b/packages/bsky/src/lexicon/types/app/bsky/embed/video.ts index 50eb59aa038..6816b027b90 100644 --- a/packages/bsky/src/lexicon/types/app/bsky/embed/video.ts +++ b/packages/bsky/src/lexicon/types/app/bsky/embed/video.ts @@ -13,6 +13,9 @@ export interface Main { /** Alt text description of the video, for accessibility. */ alt?: string aspectRatio?: AppBskyEmbedDefs.AspectRatio + /** Attribution for the video, e.g. the creator or source. */ + attribution?: string + licenseUri?: string [k: string]: unknown } diff --git a/packages/ozone/src/lexicon/lexicons.ts b/packages/ozone/src/lexicon/lexicons.ts index 5111b619dea..7f03d4e0e0a 100644 --- a/packages/ozone/src/lexicon/lexicons.ts +++ b/packages/ozone/src/lexicon/lexicons.ts @@ -5297,6 +5297,17 @@ export const schemaDict = { type: 'ref', ref: 'lex:app.bsky.embed.defs#aspectRatio', }, + attribution: { + type: 'string', + description: + 'Attribution for the video, e.g. the creator or source.', + maxGraphemes: 300, + maxLength: 3000, + }, + licenseUri: { + type: 'string', + format: 'uri', + }, }, }, caption: { diff --git a/packages/ozone/src/lexicon/types/app/bsky/embed/video.ts b/packages/ozone/src/lexicon/types/app/bsky/embed/video.ts index 50eb59aa038..6816b027b90 100644 --- a/packages/ozone/src/lexicon/types/app/bsky/embed/video.ts +++ b/packages/ozone/src/lexicon/types/app/bsky/embed/video.ts @@ -13,6 +13,9 @@ export interface Main { /** Alt text description of the video, for accessibility. */ alt?: string aspectRatio?: AppBskyEmbedDefs.AspectRatio + /** Attribution for the video, e.g. the creator or source. */ + attribution?: string + licenseUri?: string [k: string]: unknown } diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts index 5111b619dea..7f03d4e0e0a 100644 --- a/packages/pds/src/lexicon/lexicons.ts +++ b/packages/pds/src/lexicon/lexicons.ts @@ -5297,6 +5297,17 @@ export const schemaDict = { type: 'ref', ref: 'lex:app.bsky.embed.defs#aspectRatio', }, + attribution: { + type: 'string', + description: + 'Attribution for the video, e.g. the creator or source.', + maxGraphemes: 300, + maxLength: 3000, + }, + licenseUri: { + type: 'string', + format: 'uri', + }, }, }, caption: { diff --git a/packages/pds/src/lexicon/types/app/bsky/embed/video.ts b/packages/pds/src/lexicon/types/app/bsky/embed/video.ts index 50eb59aa038..6816b027b90 100644 --- a/packages/pds/src/lexicon/types/app/bsky/embed/video.ts +++ b/packages/pds/src/lexicon/types/app/bsky/embed/video.ts @@ -13,6 +13,9 @@ export interface Main { /** Alt text description of the video, for accessibility. */ alt?: string aspectRatio?: AppBskyEmbedDefs.AspectRatio + /** Attribution for the video, e.g. the creator or source. */ + attribution?: string + licenseUri?: string [k: string]: unknown } From 4ed01c8473400bb7a16851b97914285ac5b019b0 Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Mon, 2 Sep 2024 22:32:44 +0100 Subject: [PATCH 3/4] add to view --- lexicons/app/bsky/embed/video.json | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lexicons/app/bsky/embed/video.json b/lexicons/app/bsky/embed/video.json index d035de5fef9..0b91574ed57 100644 --- a/lexicons/app/bsky/embed/video.json +++ b/lexicons/app/bsky/embed/video.json @@ -69,7 +69,13 @@ "aspectRatio": { "type": "ref", "ref": "app.bsky.embed.defs#aspectRatio" - } + }, + "attribution": { + "type": "string", + "maxGraphemes": 300, + "maxLength": 3000 + }, + "licenseUri": { "type": "string", "format": "uri" } } } } From df7a1e190b575ddce12a3df4b3df83c987d27069 Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Mon, 2 Sep 2024 22:34:15 +0100 Subject: [PATCH 4/4] codegen --- packages/api/src/client/lexicons.ts | 9 +++++++++ packages/api/src/client/types/app/bsky/embed/video.ts | 2 ++ packages/bsky/src/lexicon/lexicons.ts | 9 +++++++++ packages/bsky/src/lexicon/types/app/bsky/embed/video.ts | 2 ++ packages/ozone/src/lexicon/lexicons.ts | 9 +++++++++ packages/ozone/src/lexicon/types/app/bsky/embed/video.ts | 2 ++ packages/pds/src/lexicon/lexicons.ts | 9 +++++++++ packages/pds/src/lexicon/types/app/bsky/embed/video.ts | 2 ++ 8 files changed, 44 insertions(+) diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts index 7f03d4e0e0a..db8f6b9b944 100644 --- a/packages/api/src/client/lexicons.ts +++ b/packages/api/src/client/lexicons.ts @@ -5350,6 +5350,15 @@ export const schemaDict = { type: 'ref', ref: 'lex:app.bsky.embed.defs#aspectRatio', }, + attribution: { + type: 'string', + maxGraphemes: 300, + maxLength: 3000, + }, + licenseUri: { + type: 'string', + format: 'uri', + }, }, }, }, diff --git a/packages/api/src/client/types/app/bsky/embed/video.ts b/packages/api/src/client/types/app/bsky/embed/video.ts index bd1841904ef..eae2d7968f6 100644 --- a/packages/api/src/client/types/app/bsky/embed/video.ts +++ b/packages/api/src/client/types/app/bsky/embed/video.ts @@ -56,6 +56,8 @@ export interface View { thumbnail?: string alt?: string aspectRatio?: AppBskyEmbedDefs.AspectRatio + attribution?: string + licenseUri?: string [k: string]: unknown } diff --git a/packages/bsky/src/lexicon/lexicons.ts b/packages/bsky/src/lexicon/lexicons.ts index cc1beaf7f24..ff55ad7f148 100644 --- a/packages/bsky/src/lexicon/lexicons.ts +++ b/packages/bsky/src/lexicon/lexicons.ts @@ -5350,6 +5350,15 @@ export const schemaDict = { type: 'ref', ref: 'lex:app.bsky.embed.defs#aspectRatio', }, + attribution: { + type: 'string', + maxGraphemes: 300, + maxLength: 3000, + }, + licenseUri: { + type: 'string', + format: 'uri', + }, }, }, }, diff --git a/packages/bsky/src/lexicon/types/app/bsky/embed/video.ts b/packages/bsky/src/lexicon/types/app/bsky/embed/video.ts index 6816b027b90..d6f1a777d88 100644 --- a/packages/bsky/src/lexicon/types/app/bsky/embed/video.ts +++ b/packages/bsky/src/lexicon/types/app/bsky/embed/video.ts @@ -56,6 +56,8 @@ export interface View { thumbnail?: string alt?: string aspectRatio?: AppBskyEmbedDefs.AspectRatio + attribution?: string + licenseUri?: string [k: string]: unknown } diff --git a/packages/ozone/src/lexicon/lexicons.ts b/packages/ozone/src/lexicon/lexicons.ts index 7f03d4e0e0a..db8f6b9b944 100644 --- a/packages/ozone/src/lexicon/lexicons.ts +++ b/packages/ozone/src/lexicon/lexicons.ts @@ -5350,6 +5350,15 @@ export const schemaDict = { type: 'ref', ref: 'lex:app.bsky.embed.defs#aspectRatio', }, + attribution: { + type: 'string', + maxGraphemes: 300, + maxLength: 3000, + }, + licenseUri: { + type: 'string', + format: 'uri', + }, }, }, }, diff --git a/packages/ozone/src/lexicon/types/app/bsky/embed/video.ts b/packages/ozone/src/lexicon/types/app/bsky/embed/video.ts index 6816b027b90..d6f1a777d88 100644 --- a/packages/ozone/src/lexicon/types/app/bsky/embed/video.ts +++ b/packages/ozone/src/lexicon/types/app/bsky/embed/video.ts @@ -56,6 +56,8 @@ export interface View { thumbnail?: string alt?: string aspectRatio?: AppBskyEmbedDefs.AspectRatio + attribution?: string + licenseUri?: string [k: string]: unknown } diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts index 7f03d4e0e0a..db8f6b9b944 100644 --- a/packages/pds/src/lexicon/lexicons.ts +++ b/packages/pds/src/lexicon/lexicons.ts @@ -5350,6 +5350,15 @@ export const schemaDict = { type: 'ref', ref: 'lex:app.bsky.embed.defs#aspectRatio', }, + attribution: { + type: 'string', + maxGraphemes: 300, + maxLength: 3000, + }, + licenseUri: { + type: 'string', + format: 'uri', + }, }, }, }, diff --git a/packages/pds/src/lexicon/types/app/bsky/embed/video.ts b/packages/pds/src/lexicon/types/app/bsky/embed/video.ts index 6816b027b90..d6f1a777d88 100644 --- a/packages/pds/src/lexicon/types/app/bsky/embed/video.ts +++ b/packages/pds/src/lexicon/types/app/bsky/embed/video.ts @@ -56,6 +56,8 @@ export interface View { thumbnail?: string alt?: string aspectRatio?: AppBskyEmbedDefs.AspectRatio + attribution?: string + licenseUri?: string [k: string]: unknown }