From 8e40a8ac034372b3ab1e7bd557d0be1c267d0536 Mon Sep 17 00:00:00 2001 From: Hailey Date: Sun, 7 Jul 2024 10:48:34 -0700 Subject: [PATCH 1/3] bump name max length --- lexicons/app/bsky/graph/list.json | 3 ++- packages/api/src/client/lexicons.ts | 3 ++- packages/bsky/src/lexicon/lexicons.ts | 3 ++- packages/ozone/src/lexicon/lexicons.ts | 3 ++- packages/pds/src/lexicon/lexicons.ts | 3 ++- 5 files changed, 10 insertions(+), 5 deletions(-) diff --git a/lexicons/app/bsky/graph/list.json b/lexicons/app/bsky/graph/list.json index 131114126d3..4095407a6a4 100644 --- a/lexicons/app/bsky/graph/list.json +++ b/lexicons/app/bsky/graph/list.json @@ -17,7 +17,8 @@ }, "name": { "type": "string", - "maxLength": 64, + "maxGraphemes": 64, + "maxLength": 640, "minLength": 1, "description": "Display name for list; can not be empty." }, diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts index 87c281a622b..04cd96a2a20 100644 --- a/packages/api/src/client/lexicons.ts +++ b/packages/api/src/client/lexicons.ts @@ -7839,7 +7839,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 64, + maxLength: 640, minLength: 1, description: 'Display name for list; can not be empty.', }, diff --git a/packages/bsky/src/lexicon/lexicons.ts b/packages/bsky/src/lexicon/lexicons.ts index 9eb35ce9b77..aa20b706837 100644 --- a/packages/bsky/src/lexicon/lexicons.ts +++ b/packages/bsky/src/lexicon/lexicons.ts @@ -7839,7 +7839,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 64, + maxLength: 640, minLength: 1, description: 'Display name for list; can not be empty.', }, diff --git a/packages/ozone/src/lexicon/lexicons.ts b/packages/ozone/src/lexicon/lexicons.ts index 87c281a622b..04cd96a2a20 100644 --- a/packages/ozone/src/lexicon/lexicons.ts +++ b/packages/ozone/src/lexicon/lexicons.ts @@ -7839,7 +7839,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 64, + maxLength: 640, minLength: 1, description: 'Display name for list; can not be empty.', }, diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts index 87c281a622b..04cd96a2a20 100644 --- a/packages/pds/src/lexicon/lexicons.ts +++ b/packages/pds/src/lexicon/lexicons.ts @@ -7839,7 +7839,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 64, + maxLength: 640, minLength: 1, description: 'Display name for list; can not be empty.', }, From cd3329dad50cf348492a3911682e371c40db8002 Mon Sep 17 00:00:00 2001 From: Hailey Date: Sun, 7 Jul 2024 11:10:32 -0700 Subject: [PATCH 2/3] change `listView` as well --- lexicons/app/bsky/graph/defs.json | 14 ++++++++++++-- packages/api/src/client/lexicons.ts | 6 ++++-- packages/bsky/src/lexicon/lexicons.ts | 6 ++++-- packages/ozone/src/lexicon/lexicons.ts | 6 ++++-- packages/pds/src/lexicon/lexicons.ts | 6 ++++-- 5 files changed, 28 insertions(+), 10 deletions(-) diff --git a/lexicons/app/bsky/graph/defs.json b/lexicons/app/bsky/graph/defs.json index 68dc8aa1e11..9a0325cc21f 100644 --- a/lexicons/app/bsky/graph/defs.json +++ b/lexicons/app/bsky/graph/defs.json @@ -8,7 +8,12 @@ "properties": { "uri": { "type": "string", "format": "at-uri" }, "cid": { "type": "string", "format": "cid" }, - "name": { "type": "string", "maxLength": 64, "minLength": 1 }, + "name": { + "type": "string", + "maxGraphemes": 64, + "maxLength": 640, + "minLength": 1 + }, "purpose": { "type": "ref", "ref": "#listPurpose" }, "avatar": { "type": "string", "format": "uri" }, "listItemCount": { "type": "integer", "minimum": 0 }, @@ -27,7 +32,12 @@ "uri": { "type": "string", "format": "at-uri" }, "cid": { "type": "string", "format": "cid" }, "creator": { "type": "ref", "ref": "app.bsky.actor.defs#profileView" }, - "name": { "type": "string", "maxLength": 64, "minLength": 1 }, + "name": { + "type": "string", + "maxGraphemes": 6, + "maxLength": 640, + "minLength": 1 + }, "purpose": { "type": "ref", "ref": "#listPurpose" }, "description": { "type": "string", diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts index 04cd96a2a20..f231b999be2 100644 --- a/packages/api/src/client/lexicons.ts +++ b/packages/api/src/client/lexicons.ts @@ -6844,7 +6844,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 64, + maxLength: 640, minLength: 1, }, purpose: { @@ -6894,7 +6895,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 6, + maxLength: 640, minLength: 1, }, purpose: { diff --git a/packages/bsky/src/lexicon/lexicons.ts b/packages/bsky/src/lexicon/lexicons.ts index aa20b706837..237be7bde06 100644 --- a/packages/bsky/src/lexicon/lexicons.ts +++ b/packages/bsky/src/lexicon/lexicons.ts @@ -6844,7 +6844,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 64, + maxLength: 640, minLength: 1, }, purpose: { @@ -6894,7 +6895,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 6, + maxLength: 640, minLength: 1, }, purpose: { diff --git a/packages/ozone/src/lexicon/lexicons.ts b/packages/ozone/src/lexicon/lexicons.ts index 04cd96a2a20..f231b999be2 100644 --- a/packages/ozone/src/lexicon/lexicons.ts +++ b/packages/ozone/src/lexicon/lexicons.ts @@ -6844,7 +6844,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 64, + maxLength: 640, minLength: 1, }, purpose: { @@ -6894,7 +6895,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 6, + maxLength: 640, minLength: 1, }, purpose: { diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts index 04cd96a2a20..f231b999be2 100644 --- a/packages/pds/src/lexicon/lexicons.ts +++ b/packages/pds/src/lexicon/lexicons.ts @@ -6844,7 +6844,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 64, + maxLength: 640, minLength: 1, }, purpose: { @@ -6894,7 +6895,8 @@ export const schemaDict = { }, name: { type: 'string', - maxLength: 64, + maxGraphemes: 6, + maxLength: 640, minLength: 1, }, purpose: { From b6cc88bcbb0b466a313754d0d33b3a5216a830dd Mon Sep 17 00:00:00 2001 From: Hailey Date: Sun, 7 Jul 2024 11:39:00 -0700 Subject: [PATCH 3/3] oops --- lexicons/app/bsky/graph/defs.json | 2 +- packages/api/src/client/lexicons.ts | 2 +- packages/bsky/src/lexicon/lexicons.ts | 2 +- packages/ozone/src/lexicon/lexicons.ts | 2 +- packages/pds/src/lexicon/lexicons.ts | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lexicons/app/bsky/graph/defs.json b/lexicons/app/bsky/graph/defs.json index 9a0325cc21f..42292ca3f7b 100644 --- a/lexicons/app/bsky/graph/defs.json +++ b/lexicons/app/bsky/graph/defs.json @@ -34,7 +34,7 @@ "creator": { "type": "ref", "ref": "app.bsky.actor.defs#profileView" }, "name": { "type": "string", - "maxGraphemes": 6, + "maxGraphemes": 64, "maxLength": 640, "minLength": 1 }, diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts index f231b999be2..46925c2c45d 100644 --- a/packages/api/src/client/lexicons.ts +++ b/packages/api/src/client/lexicons.ts @@ -6895,7 +6895,7 @@ export const schemaDict = { }, name: { type: 'string', - maxGraphemes: 6, + maxGraphemes: 64, maxLength: 640, minLength: 1, }, diff --git a/packages/bsky/src/lexicon/lexicons.ts b/packages/bsky/src/lexicon/lexicons.ts index 237be7bde06..8e211bdd647 100644 --- a/packages/bsky/src/lexicon/lexicons.ts +++ b/packages/bsky/src/lexicon/lexicons.ts @@ -6895,7 +6895,7 @@ export const schemaDict = { }, name: { type: 'string', - maxGraphemes: 6, + maxGraphemes: 64, maxLength: 640, minLength: 1, }, diff --git a/packages/ozone/src/lexicon/lexicons.ts b/packages/ozone/src/lexicon/lexicons.ts index f231b999be2..46925c2c45d 100644 --- a/packages/ozone/src/lexicon/lexicons.ts +++ b/packages/ozone/src/lexicon/lexicons.ts @@ -6895,7 +6895,7 @@ export const schemaDict = { }, name: { type: 'string', - maxGraphemes: 6, + maxGraphemes: 64, maxLength: 640, minLength: 1, }, diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts index f231b999be2..46925c2c45d 100644 --- a/packages/pds/src/lexicon/lexicons.ts +++ b/packages/pds/src/lexicon/lexicons.ts @@ -6895,7 +6895,7 @@ export const schemaDict = { }, name: { type: 'string', - maxGraphemes: 6, + maxGraphemes: 64, maxLength: 640, minLength: 1, },