-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fromTemplate.test.ts
to avoid intermittent error on CI
#1377
Comments
fromTemplate.test.ts
to avoid intermittent error on CIfromTemplate.test.ts
to avoid intermittent error on CI
Can second. Have faced this issue multiple times till now. |
Hello @Shurtu-gal, I am interested in working on this issue. So as suggested in the issue, do I increase the timeout period or do I need to look for a more rigorous fix to the issue? |
Although increasing timeout should work as per theory, it would be better if we solve the underlying problem unless macos requires more time. Also some logs mention failure in installation as well. ref: https://github.com/asyncapi/cli/actions/runs/8750042993/job/24012793752#step:10:419 |
I think it is happening due to this test specifically. It is testing the cli/test/integration/generate/fromTemplate.test.ts Lines 152 to 168 in 6ba4b47
|
Is there any particular reason though because of which the template generation is happening so slowly only for MacOS? |
This seems like common in other projects, For example: https://github.com/asyncapi/parser-js/actions/runs/9348904713/job/25729559713?pr=999 |
Maybe github is downgrading the mac instances or lowering the quota. Can never know 🤷🏻. |
Why do we need this improvement?
There is some error that occurs sporadically when running tests on CI since some days ago, always during the Test NodeJS PR - macos-latest job:
Besides, the error displayed points to
bundle.test.ts
instead offromTemplate.test.ts
, where the error is actually happening.cc @Souvikns
How will this change help?
This change will avoid the CI fails intermittently for the reason described on the error, so we don't need to trigger manually the GH workflow again to make the CI pass.
Screenshots
No response
How could it be implemented/designed?
The timeout set for that test might be increased or some other change should be applied to the make the test pass.
🚧 Breaking changes
No
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue?
None
The text was updated successfully, but these errors were encountered: