Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Fix BaseVariableWidthViewVector #44088

Open
ViggoC opened this issue Sep 12, 2024 · 3 comments
Open

[Java] Fix BaseVariableWidthViewVector #44088

ViggoC opened this issue Sep 12, 2024 · 3 comments

Comments

@ViggoC
Copy link

ViggoC commented Sep 12, 2024

Describe the bug, including details regarding any error messages, version, and platform.

Fix some bug in BaseVariableWidthViewVector

  1. Fix handleSafe(), while (index >= getValueCapacity()) may goes into a dead loop until the validityBufferSize is overflow when dataLength == 0,
  2. Fix copyFrom() and copyFromSafe(), the logic is wrong if fromIndex != thisIndex or the initialCapacity of the source and target vector is different.

Component(s)

Java

@vibhatha
Copy link
Collaborator

Could you please write the bug that you're trying to solve in the description?

@ViggoC
Copy link
Author

ViggoC commented Sep 12, 2024

@vibhatha The description is updated. Does it make sense to you?

@vibhatha
Copy link
Collaborator

Right, let me take look at the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants