Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy vote instructions and vote states #2597

Open
2 of 14 tasks
AshwinSekar opened this issue Aug 14, 2024 · 0 comments
Open
2 of 14 tasks

Remove legacy vote instructions and vote states #2597

AshwinSekar opened this issue Aug 14, 2024 · 0 comments
Assignees

Comments

@AshwinSekar
Copy link

AshwinSekar commented Aug 14, 2024

Problem

With the new TowerSync vote instructions, the following instructions should no longer be sent or consumed through replay and gossip:

  • Vote
  • VoteSwitch
  • UpdateVoteState
  • UpdateVoteStateSwitch
  • CompactUpdateVoteState
  • CompactUpdateVoteStateSwitch

Similarly the following vote states should no longer be supported:

  • V0_23_4
  • V1_14_11

These instructions and vote states are a maintenance burden and need to be unnecessarily replicated in new clients.

Proposed Solution

  • SIMD for vote instructions SIMD-0138: Deprecate legacy vote instructions solana-foundation/solana-improvement-documents#138
  • SIMD for vote states
  • Add feature flag to stop processing legacy instructions in the vote program
  • Add feature flag to stop deserializing legacy vote states in the vote program
  • Deprecate Ix and Tx builders
  • Deprecate old vote states
  • Migrate all tests to TowerSync
  • Activate TowerSync feature flag
  • Activate feature flag to ignore legacy vote instructions during replay
  • Activate feature flag to ignore legacy vote states during deserialization
  • Fail to parse legacy vote instructions in gossip
  • Remove all deprecated builders
  • Remove legacy instruction code
  • Remove legacy vote state code
@AshwinSekar AshwinSekar self-assigned this Aug 14, 2024
@AshwinSekar AshwinSekar changed the title Remove legacy vote instructions Remove legacy vote instructions and vote states Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant