-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect NO_PROXY
environment variable.
#668
Comments
Zicklag ***@***.***> wrote:
`NO_PROXY` environment variables. Also, it's not possible to
efficiently implement from outside of `ureq`, because you would have to
create a new `Agent` for each request to a different domain, instead of
being able to share the same agent state among all domains.
Also redirects that had different proxy needs wouldn't work.
|
I know very little about proxies. PR welcome.
Agent is reusable for multiple requests.
Not sure I follow. Do you mean there should be different proxy settings per request host? |
Martin Algesten ***@***.***> wrote:
> Also redirects that had different proxy needs wouldn't work.
Not sure I follow. Do you mean there should be different proxy settings per request host?
The point of NO_PROXY is that it does not use the proxy for certain hosts.
So, in effect, yes, there are different proxy settings (namely: none) for
some hosts.
|
ureq 3.x needs support for this. We should do all the options curl does: https://github.com/curl/curl/blob/master/docs/libcurl/opts/CURLOPT_NOPROXY.md |
With the
try_proxy_from_env(true)
option,ureq
correctly reads theHTTP[S]_PROXY
environment variables, but it doesn't honor theNO_PROXY
environment variables. Also, it's not possible to efficiently implement from outside ofureq
, because you would have to create a newAgent
for each request to a different domain, instead of being able to share the same agent state among all domains.The text was updated successfully, but these errors were encountered: