Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generated strings to use f-strings #165

Open
adonutwithsprinklez opened this issue Jan 9, 2024 · 2 comments
Open

Refactor generated strings to use f-strings #165

adonutwithsprinklez opened this issue Jan 9, 2024 · 2 comments
Assignees
Labels
enhancement New feature, rewrite, or request python Feature/bug requiring changes to Python code
Milestone

Comments

@adonutwithsprinklez
Copy link
Owner

Currently the game uses lots of "%s".format(string) to modify strings in the game. These should be refactored to use f-strings for consistency.

@adonutwithsprinklez adonutwithsprinklez added python Feature/bug requiring changes to Python code enhancement New feature, rewrite, or request labels Jan 9, 2024
@adonutwithsprinklez adonutwithsprinklez added this to the Playable Demo milestone Jan 9, 2024
@adonutwithsprinklez adonutwithsprinklez self-assigned this Jan 9, 2024
@HexDecimal
Copy link

Ruff can automatically refactor these by converting percent syntax into format UP031 then format syntax into f-strings UP032.

@adonutwithsprinklez
Copy link
Owner Author

Ruff can automatically refactor these by converting percent syntax into format UP031 then format syntax into f-strings UP032.

Interesting. I will have to look into that when I begin work on this issue. Thanks for bringing it to my attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, rewrite, or request python Feature/bug requiring changes to Python code
Projects
Development

No branches or pull requests

2 participants