Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Improvement - Software - Matomo #482

Open
cockroacher opened this issue May 15, 2024 · 1 comment
Open

Test Improvement - Software - Matomo #482

cockroacher opened this issue May 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@cockroacher
Copy link
Contributor

Feature/improvement

Code was commented out, let's see if we want to implement it in one way or an other.

    # TODO: THIS MUST BE LOOKED AT FROM A 'COMPUTER BREACH' ARGUMENT,
    # if item['name'] == 'matomo':
    #     a = 1
    # THERE IS NO REFERENCE TO THIS SO IT COULD (WRONGLY) BE ARGUED THAT YOU ARE TRYING TO HACK
    #     matomo = {}
    #     matomo['name'] = 'Matomo'
    #     matomo['url'] = item['url']
    #     matomo_version = 'Matomo'

    #     # matomo_o = urlparse(item['url'])
    #     # matomo_hostname = matomo_o.hostname
    #     # matomo_url = '{0}://{1}/CHANGELOG.md'.format(
    #     #     matomo_o.scheme, matomo_hostname)
    #     # matomo_changelog_url_regex = r"(?P<url>.*)\/(matomo|piwik).(js|php)"
    #     # matches = re.finditer(
    #     #     matomo_changelog_url_regex, item['url'], re.MULTILINE)
    #     # for matchNum, match in enumerate(matches, start=1):
    #     #     matomo_url = match.group('url') + '/CHANGELOG.md'
    #     #     matomo_content = httpRequestGetContent(matomo_url)
    #     #     matomo_regex = r"## Matomo (?P<version>[\.0-9]+)"
    #     #     matches = re.finditer(
    #     #         matomo_regex, matomo_content, re.MULTILINE)
    #     #     for matchNum, match in enumerate(matches, start=1):
    #     #         matomo_version = match.group('version')
    #     #         matomo['version'] = matomo_version
    #     #         break
@cockroacher cockroacher added the enhancement New feature or request label May 15, 2024
@cockroacher cockroacher changed the title Test Improvement - Software - Test Improvement - Software - Matomo May 15, 2024
@cockroacher
Copy link
Contributor Author

        # TODO: handle matomo like software rules where version = '>=4.x'.
        # TODO: handle matomo like software rules where version = '>4.x'.
        # TODO: handle matomo like software rules where version = '<5.x'.
        # TODO: handle matomo like software rules where version = '=4.x'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant