Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our windows build situation #233

Open
kumpera opened this issue Nov 23, 2020 · 1 comment
Open

Improve our windows build situation #233

kumpera opened this issue Nov 23, 2020 · 1 comment

Comments

@kumpera
Copy link
Contributor

kumpera commented Nov 23, 2020

Out current build story on windows needs some love.

The problem:

We currently have two build scripts for rlclientlib: cmake and msbuild.
The CI coverage of the msbuild setup is not as throughout as the cmake one.

We should improve things by either eliminating the msbuild bits (while retaining a VS experience) or by improving our CI bits.

For CI, we don't build the dotnet bits using the msbuild scripts and this triggered a regression when zstd was introduced. It's fixed by #232 but CI should catch such trivial issue.

@lokitoth
Copy link
Member

lokitoth commented Jun 7, 2021

This was partially improved in #320 and #332 (pending #335).

Remaining work here seems to be:

  • Migrate to CMake in Windows CI (should net us a nice time improvement too)
  • Deprecate non-CMake projects (need to figure out how to communicate this to downstream consumers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants