Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend advanced search filters and correct committee chair facet label #758

Open
alawvt opened this issue Aug 3, 2021 · 8 comments · Fixed by #760
Open

Extend advanced search filters and correct committee chair facet label #758

alawvt opened this issue Aug 3, 2021 · 8 comments · Fixed by #760

Comments

@alawvt
Copy link
Contributor

alawvt commented Aug 3, 2021

Modify dspace/config/spring/api/discovery.xml

Add

  • searchFilterCallnumber: LC Call Number, dc.subject.lcc (not to patent collection)
  • searchFilterJournaltitle: Journal Title, dc.title.serial (not to etd, patent collections)
  • searchFilterPublisher: Publisher, dc.publisher (not to patent collection)
  • searchFilterRights: Rights, dc.rights, dc.rights.uri (not to patent collection)
  • searchFilterVersion: Version, dc.description.version (not to etd, patent collection)

current default list

<property name="searchFilters">
            <list>
                <ref bean="searchFilterTitle" />
                <ref bean="searchFilterAuthor" />
                <ref bean="searchFilterSubject" />
                <ref bean="searchFilterIssued" />
                <ref bean="searchFilterType" />          
                <ref bean="searchFilterAbstract" />
                <ref bean="searchFilterSeries" />
                <ref bean="searchFilterIdentifier" />
                <ref bean="searchFilterSponsor" />
                <ref bean="searchFilterLanguage" />
                <ref bean="searchFilterTrnumber" />
                <ref bean="searchFilterDepartment" />
                <ref bean="searchFilterAdvisor" />
                <ref bean="searchFilterCommitteemember" />
                <ref bean="searchFilterEtdlevel" />
		<ref bean="searchFilterContentInOriginalBundle"/>
                <ref bean="searchFilterFileNameInOriginalBundle" />
                <ref bean="searchFilterFileDescriptionInOriginalBundle" />
            </list>
        </property>

final default list

<property name="searchFilters">
            <list>
                <ref bean="searchFilterTitle" />
                <ref bean="searchFilterAuthor" />
                <ref bean="searchFilterSubject" />
                <ref bean="searchFilterIssued" />
                <ref bean="searchFilterType" />          
                <ref bean="searchFilterAbstract" />
                <ref bean="searchFilterCallnumber" />
                <ref bean="searchFilterIdentifier" />
                <ref bean="searchFilterJournalTitle" />
                <ref bean="searchFilterLanguage" />
                <ref bean="searchFilterPublisher" />
                <ref bean="searchFilterRights" />
                <ref bean="searchFilterSponsor" />
                <ref bean="searchFilterSeries" />
                <ref bean="searchFilterVersion" />
                <ref bean="searchFilterTrnumber" />
                <ref bean="searchFilterDepartment" />
                <ref bean="searchFilterAdvisor" />
                <ref bean="searchFilterCommitteemember" />
                <ref bean="searchFilterEtdlevel" />
		<ref bean="searchFilterContentInOriginalBundle"/>
                <ref bean="searchFilterFileNameInOriginalBundle" />
                <ref bean="searchFilterFileDescriptionInOriginalBundle" />
            </list>
        </property>

You might reference PR #50, which customized search filters and facets for several collections.

To test, the advanced search filters and facets should match for:

  • home page
  • etd collections
  • patent collection
  • any other collection (default settings)

Also change facet label from Advisor to Committee Chair

<bean id="searchFilterAdvisor" class="org.dspace.discovery.configuration.DiscoverySearchFilterFacet">
        <property name="indexFieldName" value="advisor"/>

should be

<bean id="searchFilterAdvisor" class="org.dspace.discovery.configuration.DiscoverySearchFilterFacet">
        <property name="indexFieldName" value="committee chair"/>
@alawvt alawvt changed the title Extend advanced search filters Extend advanced search filters and correct committee chair facet label Aug 3, 2021
@alawvt
Copy link
Contributor Author

alawvt commented Aug 3, 2021

@pyc1, if there is anything you would like added to the Advanced Search or other Facets, please let me know.

@pyc1
Copy link

pyc1 commented Aug 5, 2021

Rights should be useful for sure. Maybe dc.description.version so we can document accepted manuscripts and preprints.

@alawvt
Copy link
Contributor Author

alawvt commented Aug 5, 2021

Thanks, @pyc1. I added version to the list above and implement them now.

@alawvt
Copy link
Contributor Author

alawvt commented Aug 11, 2021

Shown below are the new default advanced search filters, which seem to work as expected.
AdvancedSearchFilters_default_2021-08-11

@alawvt
Copy link
Contributor Author

alawvt commented Aug 11, 2021

Resolved with PR #760

@alawvt
Copy link
Contributor Author

alawvt commented Aug 11, 2021

Did not change Advisor facet label.

@alawvt alawvt reopened this Aug 23, 2021
@alawvt
Copy link
Contributor Author

alawvt commented Aug 23, 2021

diff --git a/dspace/config/spring/api/discovery.xml b/dspace/config/spring/api/discovery.xml
index 64456be33..e604e3e18 100644
--- a/dspace/config/spring/api/discovery.xml
+++ b/dspace/config/spring/api/discovery.xml
@@ -51,9 +51,11 @@
                <entry key="10919/5534" value-ref="etdConfiguration"/>
                <entry key="10919/11041" value-ref="etdConfiguration"/>
                <entry key="10919/9291" value-ref="etdConfiguration"/>
+               <entry key="10919/83923" value-ref="etdConfiguration"/>
                <entry key="10919/51287" value-ref="etdConfiguration"/>
                <entry key="10919/18725" value-ref="etdConfiguration"/>
                <entry key="10919/18726" value-ref="etdConfiguration"/>
+               <entry key="10919/86632" value-ref="etdConfiguration"/>
                <entry key="10919/72294" value-ref="patentConfiguration"/>
                <entry key="10919/72295" value-ref="patentConfiguration"/>
             </map>

@alawvt
Copy link
Contributor Author

alawvt commented Jan 19, 2022

Please add sort by Accession Date ascending and descending. This will be especially useful for checking recent Elements submissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants