Refactor functions to accept a range instead of a pair of iterators

[kkarbowiak]

There are multiple functions that accept a pair of iterators to denote a range, which could be refactored to accept a range (or a view). This could help raise the abstraction level a bit and make the code more readable.

In particular, is seems the following overloads

vroom/src/structures/vroom/tw_route.cpp

Lines 1477 to 1504 in 176f57a

	template void TWRoute::replace(const Input& input,
	const Amount& delivery,
	const std::vector<Index>::iterator first_job,
	const std::vector<Index>::iterator last_job,
	const Index first_rank,
	const Index last_rank);
	template void
	TWRoute::replace(const Input& input,
	const Amount& delivery,
	const std::vector<Index>::const_iterator first_job,
	const std::vector<Index>::const_iterator last_job,
	const Index first_rank,
	const Index last_rank);
	template void
	TWRoute::replace(const Input& input,
	const Amount& delivery,
	const std::vector<Index>::reverse_iterator first_job,
	const std::vector<Index>::reverse_iterator last_job,
	const Index first_rank,
	const Index last_rank);
	template void
	TWRoute::replace(const Input& input,
	const Amount& delivery,
	const std::array<Index, 1>::const_iterator first_job,
	const std::array<Index, 1>::const_iterator last_job,
	const Index first_rank,
	const Index last_rank);

could be replaced with a single one based on a view. Even the somewhat artificial code that wraps an element in a single-item-array could be replaced with a single-element-view (std::ranges::views::single).

[jcoupey]

I'm all for it: that is something I've had in mind since I first heard about ranges before they even were part of the standard! Never got around to doing it. @kkarbowiak do you want to give this a go?

[kkarbowiak]

I'm all for it: that is something I've had in mind since I first heard about ranges before they even were part of the standard! Never got around to doing it. @kkarbowiak do you want to give this a go?

Yes :-)