Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube/Vimeo Video Support #20

Open
dougfabris opened this issue Aug 17, 2020 · 6 comments
Open

Youtube/Vimeo Video Support #20

dougfabris opened this issue Aug 17, 2020 · 6 comments

Comments

@dougfabris
Copy link

Hello @VLZH

First of all, thank you for this amazing wrapper. I saw you're planning to work in video support and I really wanted to help you with that, cause I'm working on a project in React.js that needs video support in a lightbox and I don't found anything better to use instead of lightGallery :(

What do you think about it? Maybe we can discuss more this implementation and maybe I could help you with that. Did you already develop something for this resource?

@dougfabris dougfabris changed the title Youtube/Vimeo Videos Support Youtube/Vimeo Video Support Aug 17, 2020
@VLZH
Copy link
Owner

VLZH commented Aug 18, 2020

@dougfabris Thank you for this issue, i will implement video support soon.

@dougfabris
Copy link
Author

dougfabris commented Aug 18, 2020

Nice to hear from you @VLZH I was checking the code and I found a way to use youtube/Vimeo videos just passing the video URL in "src" of LightgalleryItem component's prop. Doing it we'll face an error in lg-video dependency related to this pull request . I did the correction locally and it works, but maybe will be necessary to wait for this merge to publish the video feature, I don't know... If you need help with something, let me know.

@svbutko
Copy link

svbutko commented Aug 18, 2020

Nice to hear from you @VLZH I was checking the code and I found a way to use youtube/Vimeo videos just passing the video URL in "src" of LightgalleryItem component's prop. Doing it we'll face an error in lg-video dependency related to this pull request . I did the correction locally and it works, but maybe will be necessary to wait for this merge to publish the video feature, I don't know... If you need help with something, let me know.

@dougfabris, it does support YouTube videos and it worked great up until some moment of time when we stumbled upon this issue, after my PR will be accepted I'll create another one here to bump the version of the dependency.

@dougfabris
Copy link
Author

@svbutko I suggest to include this youtube/Vimeo support in documentation with an example too. I can help with that if you guys need it. PS: In my opinion, it's the only good solution for lightbox for React.js that supports images and videos.

@vhelke
Copy link

vhelke commented Sep 22, 2020

Any progress on this? Really looking forward to the video support.

@svbutko
Copy link

svbutko commented Sep 22, 2020

Any progress on this? Really looking forward to the video support.

There's a PR which fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants