-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Alice's notes #203
Labels
enhancement
New feature or request
Milestone
Comments
A minimal rename option suggested by @alice-i-cecile: |
The animation API is resolved too, not much we can do. |
This was referenced Aug 4, 2024
Merged
See #223 for the point about spawning. |
See bevyengine/bevy#14554 for how to do sounds (thanks Alice!) |
This was referenced Aug 5, 2024
Merged
This was referenced Aug 6, 2024
Merged
All done now :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
InteractionQuery
is worth the cognitive complexity costInteractionPalette
's naming / docs aren't clear enough (I like the pattern, but it needs to be taught better)handle_title_action
should be done using observers, rather than aTitleAction
componentOnPress
callbacks #229exit_playing
and friends should be renamed to reflect a smaller scope: state transition schedules should contain multiple systems by conventiongame
module: IMO trying to further separate out gameplay logic from things like sound effects is importantWrapWithinWindow
is probably clearer asScreenWrap
MovementController
needs docsyou should be able to makeAppSet
more robust to refactors by using thePartialOrd
traitFoo
screen
is kind of a weird name for that module 🤔 Totally just a nit though, and I don't really have better suggestionsThe text was updated successfully, but these errors were encountered: