Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workspaces in release workflow #194

Open
benfrankel opened this issue Jul 25, 2024 · 1 comment
Open

Support workspaces in release workflow #194

benfrankel opened this issue Jul 25, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request ready for implementation The problem was discussed and is ready for a PR
Milestone

Comments

@benfrankel
Copy link
Collaborator

Provide an env variable (off by default) to specify a workspace sub-directory so that the release workflow can use that and Just Work.

@benfrankel benfrankel added enhancement New feature or request uncontroversial This work is generally agreed upon labels Jul 25, 2024
@benfrankel benfrankel added this to the Bevy Jam 6 milestone Jul 25, 2024
@benfrankel benfrankel self-assigned this Aug 4, 2024
@benfrankel benfrankel added ready for implementation The problem was discussed and is ready for a PR and removed uncontroversial This work is generally agreed upon labels Aug 5, 2024
@benfrankel
Copy link
Collaborator Author

benfrankel commented Aug 16, 2024

Currently this should Just Work as long as you:

  1. Set assets_path to path/to/assets if needed.
  2. Keep Trunk.toml in the root directory, with build.target pointing to path/to/web/index.html if needed.
  3. Make sure cargo build with no args will build the "main app" that you want to release. This can be done by setting the main app as the root package or one of the default-members, and setting cargo_build_binary_name if needed.

This should be explained in the workflows.md documentation.

We could still add an optional cargo_build_package env variable to be passed to cargo via --package, in case the user doesn't want to set the main app as the root package or build all of the default-members during release. However, trunk does not support --package currently (see trunk-rs/trunk#719).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready for implementation The problem was discussed and is ready for a PR
Projects
None yet
Development

No branches or pull requests

1 participant