-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint suggestion: Prefer use x::y;
over use x::prelude::y;
#96
Comments
use x::y;
over use x::prelude::y;
use x::y;
over use x::prelude::y;
If we don't want to treat "prelude" as a special symbol, then we could generalize it to prefer "sub-paths". |
Is there anything particularly wrong with using the import from the prelude? Imo this is more of a style thing that would be better implemented in |
@alice-i-cecile I see on Discord that you like this lint. Could you post some motivation? |
This is a "stylistic consistency" lint. It's helpful to reduce visual clutter and merge conflicts on imports. I also think that the reverse (prefer prelude) should be included. Clippy has a number of these, see |
I can definitely see the stylistic reasoning behind this, but I think for now it should be disabled by default.
|
Yep, fully agree on disabled-by-default: I think that the whole style category should be. |
The text was updated successfully, but these errors were encountered: