Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main_return_without_appexit and insert_event_resource do not lint against alternative method syntax #94

Open
BD103 opened this issue Sep 19, 2024 · 0 comments
Labels
A-CI Related to CI and GitHub Actions C-Bug A bug in the program

Comments

@BD103
Copy link
Member

BD103 commented Sep 19, 2024

The following code does not raise any warnings:

#[derive(Event)]
struct MyEvent;

fn main() {
    let mut app = App::new();
    App::init_resource::<Events<MyEvent>>(&mut app);
    App::run(&mut app);
}

This is likely because both lints match against just ExprKind::MethodCall, when they should also be looking for normal function calls.

Not sure if this bug will come up often, so this is probably low-priority.

@BD103 BD103 added A-CI Related to CI and GitHub Actions C-Bug A bug in the program labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Related to CI and GitHub Actions C-Bug A bug in the program
Projects
None yet
Development

No branches or pull requests

1 participant