Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typed returns for MultiPassBox.get_identity(...) in typescript #9

Open
ashneverdawn opened this issue Jul 3, 2024 · 1 comment

Comments

@ashneverdawn
Copy link
Contributor

When MultiPassBox.get_identity(...) is exported to typescript, the return type is Promise<any>
We want any to be typed. (In rust it's a Vec<Identity>).

Furthermore, consider splitting .get_identity(...) into separate functions for it's variants (DID, DIDList, Username) so that DID and Username variants can return just an Identity instead of a Vec<Identity> with a single element.

@dariusc93
Copy link

dariusc93 commented Jul 3, 2024

Given that MultiPass::get_identity is now returns a stream, we could probably convert the exported function to return an asynciter for the stream side (by default) and have a separate function for a single identity. See Satellite-im/Warp#554

@dariusc93 dariusc93 reopened this Sep 12, 2024
@dariusc93 dariusc93 transferred this issue from Satellite-im/Warp Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants