Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-select]: fast navigation to options doesn't work after submit #9757

Open
1 task done
nnaydenow opened this issue Aug 27, 2024 · 1 comment · May be fixed by #9865
Open
1 task done

[ui5-select]: fast navigation to options doesn't work after submit #9757

nnaydenow opened this issue Aug 27, 2024 · 1 comment · May be fixed by #9865
Assignees
@NakataCode
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@nnaydenow
Copy link
Contributor

nnaydenow commented Aug 27, 2024 •
edited
Loading

Bug Description

ui5-select provides option to navigate to specific option if the option's text starts with the respective typed text.

Pressing Enter key closes the popover and confirms the selection of the selected option but doesn't clear the typed characters. With that starting to type new word doesn't change selection.

This affects some test execution since some of the tests doesn't reload the page and they are using the same select.

Isolated example

Affected Component

No response

Expected Behaviour

If option is selected by Enter key and then new word is typed, the selection to be moved to the new word

Isolated Example

No response

Steps to Reproduce

  1. Open example
  2. Open picker
  3. Type a
  4. Press enter right after typing a
  5. When the picker is closed press one of the others letters: b/c/d
    ...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

nightly

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@nnaydenow nnaydenow added the bug This issue is a bug in the code label Aug 27, 2024
@elenastoyanovaa elenastoyanovaa self-assigned this Aug 27, 2024
@elenastoyanovaa
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-p ,

The issue is reproducible, but the interaction should be done fast. Type a, then press Enter and immediately press b - the selection is not moved to the second item. If the same is performed slowly, the issue is not reproducible.

It is a relevant use case as the tests are failing due to the 1s timeout logic for clearing a _typedChars.

Kind Regards,
Elena

@elenastoyanovaa elenastoyanovaa removed their assignment Aug 27, 2024
@NakataCode NakataCode self-assigned this Sep 5, 2024
@NakataCode NakataCode linked a pull request Sep 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NakataCode NakataCode

Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-select): improve selection change handling SAP/ui5-webcomponents
3 participants
@elenastoyanovaa @nnaydenow @NakataCode