Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GTest type from integration testing to unit testing. #3141

Open
CAHEK7 opened this issue Jul 23, 2024 · 0 comments
Open

Switch GTest type from integration testing to unit testing. #3141

CAHEK7 opened this issue Jul 23, 2024 · 0 comments
Labels

Comments

@CAHEK7
Copy link
Contributor

CAHEK7 commented Jul 23, 2024

Some of the test in a current test suite are intended to be unit tests, but for historical reasons they were implemented as integration, which included whole library pipeline, but limited algorithm applicability using environmental variables.
Those tests must be rewritten as unit tests calling particular algorithms directly.

The test driver and string arguments must be removed.

A short, but not complete, list of the tests:

  1. smoke_* tests, for example: https://github.com/ROCm/MIOpen/blob/develop/test/gtest/smoke_solver_ConvAsmImplicitGemmGTCDynamicFwdDlopsNCHWC.cpp
  2. regression_* tests, for example: https://github.com/ROCm/MIOpen/blob/develop/test/gtest/regression_half_vega.cpp
  3. various algorithms tests, has to be defined, for example: https://github.com/ROCm/MIOpen/blob/develop/test/gtest/reduce_custom_fp32.cpp
@CAHEK7 CAHEK7 added the GTest label Jul 23, 2024
@CAHEK7 CAHEK7 mentioned this issue Jul 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant