Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests use MIOpen internal APIs #3094

Open
xuantengh opened this issue Jul 2, 2024 · 0 comments
Open

Tests use MIOpen internal APIs #3094

xuantengh opened this issue Jul 2, 2024 · 0 comments

Comments

@xuantengh
Copy link
Contributor

xuantengh commented Jul 2, 2024

Hi developers,

MIOpen tests directly leverage internal APIs (e.g., miopen::ActivationDescriptor) rather than public APIs miopenCreateActivationDescriptor to implement the functionalities. This makes the shared library libMIOpen.so has to expose many unnecessary symbols.

Currently MIOpen uses the version script to control the symbol visibility, while other ROCm libraries like rocBLAS or rocSPARSE hide all internal symbols by default as their tests only use public APIs.

Distributions like Debian will maintain a symbol file for library binary compatibility between packages, hence the internal API usage in tests makes it hard to provide a clean symbol list with only public APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant